> On March 13, 2014, 8:55 p.m., Terence Yim wrote: > > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java, line 107 > > <https://reviews.apache.org/r/19151/diff/3/?file=517926#file517926line107> > > > > Why you want to get the parent of system classloader? I thought you > > want to use system classloader as the parent of the URLClassLoader. > > Jiahua Wang wrote: > I'm using the parent of system classloader b/c system classloader has the > Twill classes and dependencies (including Guava 13), so loading the Presto > stuff into a child classloader of the system classloader would cause Guava > conflicts.
Defaulted parent of classloader to be the system classloader. - Jiahua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19151/#review37106 ----------------------------------------------------------- On March 14, 2014, 12:18 a.m., Jiahua Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19151/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 12:18 a.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Implement a TwillApplication that runs bundled jars. This is to allow user > programs to run without having to worry about dependency conflicts with > Twill. For example, Presto uses Guava 16 whereas Twill uses Guava 13, so they > can't run in the same class loader. > > See JarRunnerExample (in twill-examples) for example usage of > BundledJarApplication (in twill-ext). > > > Diffs > ----- > > pom.xml 8e93850 > twill-api/src/main/java/org/apache/twill/api/LocalFile.java bcc3e13 > > twill-api/src/main/java/org/apache/twill/internal/DefaultResourceSpecification.java > 2998165 > > twill-core/src/main/java/org/apache/twill/internal/json/ResourceSpecificationCodec.java > 5f7d7ae > twill-examples/echo/pom.xml PRE-CREATION > twill-examples/echo/src/main/java/echo/EchoMain.java PRE-CREATION > twill-examples/pom.xml PRE-CREATION > twill-examples/yarn/pom.xml PRE-CREATION > > twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/BundledJarExample.java > PRE-CREATION > > twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/ConfigDrivenBundledJarExample.java > PRE-CREATION > > twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/HelloWorld.java > PRE-CREATION > twill-ext/pom.xml PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java > PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunnable.java > PRE-CREATION > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java > PRE-CREATION > > twill-ext/src/main/java/org/apache/twill/ext/ConfigDrivenBundledJarApplication.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19151/diff/ > > > Testing > ------- > > Tested JarRunnerExample on a single node cluster. Also tested a Twill > application that starts up multiple runnables that run Presto services. > > > Thanks, > > Jiahua Wang > >
