-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19151/
-----------------------------------------------------------

(Updated March 17, 2014, 8:59 p.m.)


Review request for Twill.


Changes
-------

Style fixes.


Repository: twill


Description
-------

Implement a TwillApplication that runs bundled jars. This is to allow user 
programs to run without having to worry about dependency conflicts with Twill. 
For example, Presto uses Guava 16 whereas Twill uses Guava 13, so they can't 
run in the same class loader.

See JarRunnerExample (in twill-examples) for example usage of 
BundledJarApplication (in twill-ext).


Diffs (updated)
-----

  pom.xml 8e93850 
  twill-api/src/main/java/org/apache/twill/api/LocalFile.java bcc3e13 
  
twill-api/src/main/java/org/apache/twill/internal/DefaultResourceSpecification.java
 2998165 
  
twill-core/src/main/java/org/apache/twill/internal/json/ResourceSpecificationCodec.java
 5f7d7ae 
  twill-examples/echo/pom.xml PRE-CREATION 
  twill-examples/echo/src/main/java/echo/EchoMain.java PRE-CREATION 
  twill-examples/pom.xml PRE-CREATION 
  twill-examples/yarn/pom.xml PRE-CREATION 
  
twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/BundledJarExample.java
 PRE-CREATION 
  
twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/ConfigDrivenBundledJarExample.java
 PRE-CREATION 
  
twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/HelloWorld.java 
PRE-CREATION 
  twill-ext/pom.xml PRE-CREATION 
  twill-ext/src/main/java/org/apache/twill/ext/BundledJarApplication.java 
PRE-CREATION 
  twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunnable.java 
PRE-CREATION 
  twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java 
PRE-CREATION 
  
twill-ext/src/main/java/org/apache/twill/ext/ConfigDrivenBundledJarApplication.java
 PRE-CREATION 
  twill-ext/src/main/java/org/apache/twill/ext/RunnableConfig.java PRE-CREATION 
  twill-ext/src/test/java/org/apache/twill/ext/BundledJarRunnableTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/19151/diff/


Testing
-------

Tested JarRunnerExample on a single node cluster. Also tested a Twill 
application that starts up multiple runnables that run Presto services.


Thanks,

Jiahua Wang

Reply via email to