----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22171/#review46507 -----------------------------------------------------------
twill-discovery-core/src/main/java/org/apache/twill/discovery/ZKDiscoveryService.java <https://reviews.apache.org/r/22171/#comment81914> Why need to move all these logic into a NodeService class? I don't see the NodeService is used elsewhere. twill-synchronization-core/src/main/java/org/apache/twill/synchronization/ZKSynchronizationService.java <https://reviews.apache.org/r/22171/#comment81915> Unused import? - Terence Yim On June 10, 2014, 11:13 p.m., Erick Tryzelaar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22171/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 11:13 p.m.) > > > Review request for Twill. > > > Repository: twill > > > Description > ------- > > Good evening, > > This patch series is my first cut at implementing distributed barriers for > twill. I expect it will need to go through a couple iterations before > landing, but the tests pass in IntelliJ, although I'm running into some > timeouts with running `mvn package` directly. > > It also includes the patches from https://reviews.apache.org/r/21988/ which > are needed to get twill to run on my machine. > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > pom.xml 8535d49fcc8c353ff6d442487f047577f87619a8 > twill-api/pom.xml 570d86431b98394ce19065f7099d05697c1165e5 > twill-api/src/main/java/org/apache/twill/api/TwillContext.java > f7a7ac13aaafa814486cbb1aadece3b46abed836 > twill-api/src/main/java/org/apache/twill/api/TwillController.java > 7c5089d243129e1aee0285a70b826b6062c7d8ba > twill-core/pom.xml 2ff3aa9d8b27604d3383a37e116ced906111f629 > > twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java > bf206160afc3c0ac2675f7da292593189b7a4ae2 > twill-core/src/main/java/org/apache/twill/internal/BasicTwillContext.java > 4a503e03fefbfb2dedac00c3117f4e424bb4abe7 > > twill-discovery-core/src/main/java/org/apache/twill/discovery/ZKDiscoveryService.java > f29d9864c3d524b4a62767224735b5a380d33b8a > > twill-examples/yarn/src/main/java/org/apache/twill/example/yarn/HelloWorld.java > 8dc83ff24f02e946405bfb051b194d5c39bb2618 > twill-ext/src/main/java/org/apache/twill/ext/BundledJarRunner.java > 6b9a15d5e71cd134671c415b2029905a71a69088 > twill-synchronization-api/pom.xml PRE-CREATION > > twill-synchronization-api/src/main/java/org/apache/twill/synchronization/DoubleBarrier.java > PRE-CREATION > > twill-synchronization-api/src/main/java/org/apache/twill/synchronization/SynchronizationService.java > PRE-CREATION > > twill-synchronization-api/src/main/java/org/apache/twill/synchronization/SynchronizationServiceClient.java > PRE-CREATION > twill-synchronization-core/pom.xml PRE-CREATION > > twill-synchronization-core/src/main/java/org/apache/twill/synchronization/InMemorySynchronizationService.java > PRE-CREATION > > twill-synchronization-core/src/main/java/org/apache/twill/synchronization/ZKDoubleBarrier.java > PRE-CREATION > > twill-synchronization-core/src/main/java/org/apache/twill/synchronization/ZKSynchronizationService.java > PRE-CREATION > > twill-synchronization-core/src/test/java/org/apache/twill/synchronization/InMemorySynchronizationServiceTest.java > PRE-CREATION > > twill-synchronization-core/src/test/java/org/apache/twill/synchronization/SynchronizationServiceTestBase.java > PRE-CREATION > > twill-synchronization-core/src/test/java/org/apache/twill/synchronization/ZKSynchronizationServiceTest.java > PRE-CREATION > twill-synchronization-core/src/test/resources/logback-test.xml PRE-CREATION > twill-yarn/pom.xml 1d706453070b268dba3d32f1c58c7f63c13686a1 > twill-yarn/src/main/java/org/apache/twill/internal/ContainerExitCodes.java > 22576a9980bc0fee58681c7689b1622989cc2d32 > > twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerMain.java > c3aece691fb5d5f388c5b316a79b911ca7421e58 > twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java > 5afd67981fdfc514cb06150cc8a79b43e0a13b07 > twill-yarn/src/test/java/org/apache/twill/yarn/DoubleBarrierTest.java > PRE-CREATION > twill-zookeeper/src/main/java/org/apache/twill/zookeeper/NodeService.java > PRE-CREATION > twill-zookeeper/src/main/java/org/apache/twill/zookeeper/ZKOperations.java > 0e2239dce51055a11e394846b3cd56bd2b4aba03 > > Diff: https://reviews.apache.org/r/22171/diff/ > > > Testing > ------- > > Tests ran through IntelliJ. > > > Thanks, > > Erick Tryzelaar > >
