----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22171/ -----------------------------------------------------------
(Updated July 30, 2014, 11:08 p.m.) Review request for Twill. Changes ------- Additional changes to rebase patch onto twill HEAD, and address comments, and fix a variety of other bugs. Repository: twill Description ------- Good evening, This patch series is my first cut at implementing distributed barriers for twill. I expect it will need to go through a couple iterations before landing, but the tests pass in IntelliJ, although I'm running into some timeouts with running `mvn package` directly. It also includes the patches from https://reviews.apache.org/r/21988/ which are needed to get twill to run on my machine. Diffs (updated) ----- pom.xml dfb73947725ea5c59821b8823acee0790198362d twill-api/pom.xml c0f1b98d57c45eadbe561b867f9813cf3e98ad7e twill-api/src/main/java/org/apache/twill/api/TwillContext.java 10f44991bc7c8b0d40189e7056a0f6664b433b58 twill-api/src/main/java/org/apache/twill/api/TwillController.java 7c5089d243129e1aee0285a70b826b6062c7d8ba twill-core/pom.xml 2a4e1b784ed6b78bc1b4f0a82dbee1668ada3127 twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java bf206160afc3c0ac2675f7da292593189b7a4ae2 twill-core/src/main/java/org/apache/twill/internal/BasicTwillContext.java 6eb3072fb979901a8976805f51d757e05087e1b4 twill-synchronization-api/pom.xml PRE-CREATION twill-synchronization-api/src/main/java/org/apache/twill/synchronization/DoubleBarrier.java PRE-CREATION twill-synchronization-api/src/main/java/org/apache/twill/synchronization/SynchronizationService.java PRE-CREATION twill-synchronization-api/src/main/java/org/apache/twill/synchronization/SynchronizationServiceClient.java PRE-CREATION twill-synchronization-core/pom.xml PRE-CREATION twill-synchronization-core/src/main/java/org/apache/twill/synchronization/InMemorySynchronizationService.java PRE-CREATION twill-synchronization-core/src/main/java/org/apache/twill/synchronization/ZKDoubleBarrier.java PRE-CREATION twill-synchronization-core/src/main/java/org/apache/twill/synchronization/ZKSynchronizationService.java PRE-CREATION twill-synchronization-core/src/test/java/org/apache/twill/synchronization/InMemorySynchronizationServiceTest.java PRE-CREATION twill-synchronization-core/src/test/java/org/apache/twill/synchronization/SynchronizationServiceTestBase.java PRE-CREATION twill-synchronization-core/src/test/java/org/apache/twill/synchronization/ZKSynchronizationServiceTest.java PRE-CREATION twill-synchronization-core/src/test/resources/logback-test.xml PRE-CREATION twill-yarn/pom.xml e044e1c1c305a96b2e2e54de70085469a1645234 twill-yarn/src/main/java/org/apache/twill/internal/container/TwillContainerMain.java 5c9aa455941b9e5037538403ee4d4cb27b783eed twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillController.java 5afd67981fdfc514cb06150cc8a79b43e0a13b07 twill-yarn/src/test/java/org/apache/twill/yarn/DoubleBarrierTestRun.java PRE-CREATION twill-yarn/src/test/java/org/apache/twill/yarn/YarnTestSuite.java b8a3915f5d70a01ae6f5018eee40e718ed56b15e twill-zookeeper/src/main/java/org/apache/twill/zookeeper/ZKOperations.java 0e2239dce51055a11e394846b3cd56bd2b4aba03 twill-zookeeper/src/test/java/org/apache/twill/zookeeper/ZKClientTest.java b0c7507cfb204897d8e193fbd9f30b9df6c66460 Diff: https://reviews.apache.org/r/22171/diff/ Testing ------- Tests ran through IntelliJ. Thanks, Erick Tryzelaar
