Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/52#discussion_r34297349
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractZKServiceController.java
---
@@ -220,6 +232,127 @@ public void process(WatchedEvent event) {
}
/**
+ * Send update message to all instances of a runnnable.
+ *
+ * @param command The command to be sent in the message to the Twill
cluster.
+ * @param runnableName The name of the Twill runnable to restart.
+ * @return A {@link Future} that could executed by caller to get the
result.
+ */
+ protected <V> ListenableFuture<List<V>>
updateAllRunnableInstances(String command, String runnableName) {
--- End diff --
This method should be in the `AbstractTwillController`. Only the
`TwillController` knows about "runnable". This class should only know about
ZooKeeper, but not runnable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
