Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/52#discussion_r34300767
--- Diff:
twill-api/src/main/java/org/apache/twill/api/UpdateRunnableStateResult.java ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.twill.api;
+
+import java.util.Objects;
+
+/**
+ * Represent the result of updating state for a {@link TwillRunnable}
instance.
+ */
+public class UpdateRunnableStateResult {
+ private final String command;
+ private final String status;
+ private final int instanceId;
+ private final String runnableName;
+
+ public UpdateRunnableStateResult(String command, String status, int
instanceId, String runnableName) {
+ this.command = command;
--- End diff --
The command is the actual operation done to restart the instances. The
UpdateRunnableStateResult could be used to serve other commands or operations
such as suspend hence the inclusion of the actual command send to the Twill app
master.
I could rename it to operation if it helps reduce the confusion?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
