[
https://issues.apache.org/jira/browse/TWILL-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904793#comment-14904793
]
ASF GitHub Bot commented on TWILL-153:
--------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/63#discussion_r40227034
--- Diff:
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java
---
@@ -70,8 +72,8 @@ public Hadoop20YarnAppClient(Configuration configuration)
{
}
@Override
- public ProcessLauncher<ApplicationId> createLauncher(TwillSpecification
twillSpec,
- @Nullable String
schedulerQueue) throws Exception {
+ public ProcessLauncher<ApplicationMasterInfo>
createLauncher(TwillSpecification twillSpec,
+ @Nullable
String schedulerQueue) throws Exception {
--- End diff --
Small nit on formatting, is that extra tab chars? Wondering why it has
different green shade?
> Twill containers should use the container size allocated by YARN
> ----------------------------------------------------------------
>
> Key: TWILL-153
> URL: https://issues.apache.org/jira/browse/TWILL-153
> Project: Apache Twill
> Issue Type: Improvement
> Reporter: Sreevatsan Raman
> Assignee: Terence Yim
>
> In a scenario where cluster's min container size is set at 1024MB and if the
> twill requests just 512MB, the resources that will be used by the container
> will be set at 512MB even though YARN returns a 1024MB container.
> Twill should be able to use the resources allocated by YARN
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
