[
https://issues.apache.org/jira/browse/TWILL-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14905177#comment-14905177
]
ASF GitHub Bot commented on TWILL-153:
--------------------------------------
Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/63#discussion_r40252113
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/utils/Resources.java ---
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.twill.internal.utils;
+
+/**
+ * Utility class to help adjusting container resource requirement.
+ */
+public final class Resources {
+
+ /**
+ * Computes the max heap size for a JVM process.
+ *
+ * @param containerMemory memory in MB of the container memory memory.
--- End diff --
`... container memory memory` - memory repeated.
> Twill containers should use the container size allocated by YARN
> ----------------------------------------------------------------
>
> Key: TWILL-153
> URL: https://issues.apache.org/jira/browse/TWILL-153
> Project: Apache Twill
> Issue Type: Improvement
> Reporter: Sreevatsan Raman
> Assignee: Terence Yim
>
> In a scenario where cluster's min container size is set at 1024MB and if the
> twill requests just 512MB, the resources that will be used by the container
> will be set at 512MB even though YARN returns a 1024MB container.
> Twill should be able to use the resources allocated by YARN
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
