[
https://issues.apache.org/jira/browse/TWILL-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997537#comment-14997537
]
ASF GitHub Bot commented on TWILL-63:
-------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/66#discussion_r44343615
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ApplicationBundler.java ---
@@ -145,41 +145,63 @@ public void createBundle(Location target, Class<?>
clz, Class<?>...classes) thro
* @throws IOException
*/
public void createBundle(Location target, Iterable<Class<?>> classes,
Iterable<URI> resources) throws IOException {
- LOG.debug("start creating bundle {}. building a temporary file locally
at first", target.getName());
+ createBundleAndGetClassPathUrls(target, classes, resources);
+ }
+
+ public Set<URL> createBundleAndGetClassPathUrls(Location target,
Iterable<Class<?>> classes,
--- End diff --
Who call this? Seems like it's only called in this class (from above
method). Maybe the private one can be called directly?
> Speed up application launch time
> --------------------------------
>
> Key: TWILL-63
> URL: https://issues.apache.org/jira/browse/TWILL-63
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 0.2.0-incubating
> Reporter: Terence Yim
> Assignee: Shankar Selvam
> Fix For: 0.7.0-incubating
>
>
> Currently when launching an application, two new jars are always created
> locally, one for AM (appMaster.jar) and one for Container (container.jar) and
> copied to HDFS before submitting the application. The jar files could
> potentially be big and if it doesn't changed, it should require copying to
> HDFS again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
