[
https://issues.apache.org/jira/browse/TWILL-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997622#comment-14997622
]
ASF GitHub Bot commented on TWILL-63:
-------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/incubator-twill/pull/66#discussion_r44347994
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
@@ -175,6 +189,27 @@ protected void shutDown() throws Exception {
};
}
+ private File createTwillJar() throws IOException {
+ ApplicationBundler applicationBundler = new ApplicationBundler(new
ClassAcceptor());
+ List<Class<?>> classes = Lists.newArrayList();
+ classes.add(ApplicationMasterMain.class);
+ classes.add(TwillContainerMain.class);
+ // Stuck in the yarnAppClient class to make bundler being able to
pickup the right yarn-client version
+ classes.add(yarnAppClient.getClass());
+ String parentDir = yarnConfig.get(Constants.TWILL_JAR_LOCATION,
Constants.DEFAULT_TWILL_JAR_LOCATION);
+ File twillJarFile = new File(parentDir + Constants.Files.TWILL_JAR);
+
+ Set<URL> twillClassPathURLs =
applicationBundler.createBundleAndGetClassPathUrls(twillJarFile,
+
classes, ImmutableList.<URI>of());
+ List<URL> normalizeTwillURLs = new ArrayList<>();
+ for (URL url : twillClassPathURLs) {
+ normalizeTwillURLs.add(new File(url.getPath()).toURI().toURL());
+ }
+
+ twillClassLoader = new URLClassLoader(normalizeTwillURLs.toArray(new
URL[normalizeTwillURLs.size()]), null);
--- End diff --
Who will close this ClassLoader?
> Speed up application launch time
> --------------------------------
>
> Key: TWILL-63
> URL: https://issues.apache.org/jira/browse/TWILL-63
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Affects Versions: 0.2.0-incubating
> Reporter: Terence Yim
> Assignee: Shankar Selvam
> Fix For: 0.7.0-incubating
>
>
> Currently when launching an application, two new jars are always created
> locally, one for AM (appMaster.jar) and one for Container (container.jar) and
> copied to HDFS before submitting the application. The jar files could
> potentially be big and if it doesn't changed, it should require copying to
> HDFS again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
