On 8/9/2013 4:49 PM, Richard Eckart de Castilho wrote: > Whops! How did that happen? (Well I can imagine how, but I wonder why > svn didn't bitterly complain about inconsistent line endings). SVN only complains if the file has "eol-style:native" set, I think.
The CHANGES file has nothing set. This is probably due to using the standard svn configuration for this (see http://apache.org/dev/svn-eol-style.txt which is missing an entry for CHANGES :-) -M > > I'll batch-convert to Unix-style. > > Thanks for pointing this out. > > -- Richard > > Am 09.08.2013 um 22:45 schrieb Marshall Schor <[email protected]>: > >> On 8/9/2013 4:04 PM, Richard Eckart de Castilho wrote: >>> I downloaded the source release from the staging spot and extract it. >>> Then I checked out the tag from svn. >>> Then I "diff" the two folders. I get some differences, due to hidden >>> files (e.g. .settings), but the line endings are all the same. I converted >>> one file using unix2dos to see if diff possibly ignores the line endings, >>> but then it barked - so the diff is reliable. I used diff as a base line >>> as not to include potentially converting tooling (e.g. Eclipse) into the >>> mix. >>> >>> The line endings in the source release should be unix style (I am on OS X). >>> The ones from the svn tag should be depending on your platform. >>> >>> Is it possible that you have set your Eclipse to use Windows line endings in >>> Java files and Unix endings in XML files or something like that? >> I think what threw me off was things like the uimafit-core/CHANGES file, >> which >> mostly has (in the source-release zip) "lf", but on line 91, it has "crlf". >> I >> was assuming the files had consistent line endings... >> >> -Marshall >>> -- Richard >>> >>> Am 09.08.2013 um 21:11 schrieb Marshall Schor <[email protected]>: >>> >>>> Maybe an issue, maybe not... >>>> >>>> One of the checks I often do is to verify that the source-release >>>> corresponds to >>>> the svn tag, more-or-less. >>>> >>>> To do this, I export the svn tag, and I unzip the source, and then I put >>>> these >>>> into a testing Eclipse project, select both root folders, and say >>>> compare-with-each-other. >>>> >>>> In this project, that doesn't work, due to line ending issues. >>>> >>>> The source-zip seems to have mixture of line endings, in various files. >>>> I thought that most of them were "lf", but then I saw a bunch that had >>>> "crlf". >>>> >>>> Examples: the pom.xml in core has "lf", but java files have "crlf". >>>> My svn export has both of these files having crlf, because the svn >>>> property of >>>> eol-style:native is set for both of these, and I'm working on a Windows >>>> machine. >>>> >>>> This seems puzzling, because both the Java files and the pom have the svn >>>> property set: eol-style:native. It would seem that the build would check >>>> out >>>> this stuff on one kind of machine, so all these files should have the same >>>> line >>>> endings. Any idea how it happened that the source-release.zip ended up >>>> with >>>> files having different line endings? >>>> >>>> -Marshall >
