[ 
https://issues.apache.org/jira/browse/UIMA-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803048#comment-13803048
 ] 

Richard Eckart de Castilho commented on UIMA-2387:
--------------------------------------------------

After a quick look at the diff, it appears that it is not minimal. There seem 
to be differences in the handling of whitespace in the diff. This might appear 
trivial, but it makes it take longer to see which lines are actually affected 
by the change. The patch also removes lines that are not relevant to the change.

Can you provide a minimal patch against the current version?

> ResultingAnnotationName not optional in ConceptMapper
> -----------------------------------------------------
>
>                 Key: UIMA-2387
>                 URL: https://issues.apache.org/jira/browse/UIMA-2387
>             Project: UIMA
>          Issue Type: Bug
>          Components: addons, Sandbox-ConceptMapper
>    Affects Versions: 2.3.1Addons
>            Reporter: Jens Grivolla
>            Priority: Minor
>         Attachments: UIMA-2387.patch
>
>
> Contrary to the documentation, the ResultingAnnotationName is not optional in 
> the ConceptMapper descriptor. In our use case we only want to write back 
> information to the original token, without creating a new annotation. Instead 
> of treating this as a documentation bug it is therefore better to fix the 
> code.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to