[
https://issues.apache.org/jira/browse/UIMA-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804312#comment-13804312
]
Jens Grivolla commented on UIMA-2387:
-------------------------------------
I agree that the diff is not very pleasant to read, but it seems that the
whitespace differences are due to chunks of code getting moved into an "if"
block and thus increasing the indentation level. Other than some deleted blank
lines it seems to me that all lines that appear in the diff are legitimately
affected by the change. It's true that there is some inconsistency in
indentation (2 vs. 4 spaces), but no reformatting of the existing code as far
as I can see.
How can I get it to be more readable?
> ResultingAnnotationName not optional in ConceptMapper
> -----------------------------------------------------
>
> Key: UIMA-2387
> URL: https://issues.apache.org/jira/browse/UIMA-2387
> Project: UIMA
> Issue Type: Bug
> Components: addons, Sandbox-ConceptMapper
> Affects Versions: 2.3.1Addons
> Reporter: Jens Grivolla
> Priority: Minor
> Attachments: UIMA-2387.patch
>
>
> Contrary to the documentation, the ResultingAnnotationName is not optional in
> the ConceptMapper descriptor. In our use case we only want to write back
> information to the original token, without creating a new annotation. Instead
> of treating this as a documentation bug it is therefore better to fix the
> code.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
