Hi,

Am 11.02.2014 20:50, schrieb Marshall Schor:
> (These are probably not release blockers) - When building from the sources, I
> observed:
>
> ruta-ep-engine bundle gives these warnings, probably needs a pom update?
>
> [INFO] --- maven-bundle-plugin:2.3.7:manifest (uima-bundle) @ ruta-ep-engine 
> ---
> [WARNING] Manifest org.apache.uima:ruta-ep-engine:jar:2.2.0 : Did not find
> matching referal for !antlr
> [WARNING] Manifest org.apache.uima:ruta-ep-engine:jar:2.2.0 : Did not find
> matching referal for !com.jamonapi
> [WARNING] Manifest org.apache.uima:ruta-ep-engine:jar:2.2.0 : Did not find
> matching referal for !org.apache.commons.pool
> [WARNING] Manifest org.apache.uima:ruta-ep-engine:jar:2.2.0 : Did not find
> matching referal for !org.apache.commons.pool.impl

Hmm, I don't think that's a problem. I had to explicitly exclude all
packages in order to get it to work, but afterwards I applied some
cleanups, which probably made these four exclusions redundant. I think I
can remove them again.

> ruta-ep-ide 2.2.0 has antlr warning:
>
> org\apache\uima\ruta\ide\core\parser\RutaParser.g
> warning(200): org\apache\uima\ruta\ide\core\parser\RutaParser.g:2057:2: 
> Decision
> can match input such as "MINUS Identifier" using multiple alternatives: 1, 2
> As a result, alternative(s) 2 were disabled for that input
> Semantic predicates were present but were hidden by actions.
>
> Is this OK?

I have seen that. It is not OK, but also not a big problem. The
consequences are that the AST for numerical difference (hyphen-minus) on
feature match values is broken, and thus the support in the editor,
e.g., semantic highlighting is missing. However, that is only for
something like: ASSIGN(var, Token.end - Token.begin). The actual rule
functionality is not affected. I will create an issue so that I will not
forget to fix it in the next release. If I find the time, I will do it
for the next rc.

>
> I also note that there were quite a few javadoc warnings - some wrong spelling
> for parameter names, @return with no arguments, etc.  (We generally try to 
> have
> the public user-facing APIs have good javadocs, but, it's not a blocker IMHO.)

JavaDoc is still a big problem, because it is mostly missing at all. It
was never a top priority for me because ruta is not a java library where
you call different methods. There is an issue for it.

Best,

Peter






> -Marshall
>

Reply via email to