I'll make the methods private and I'll take a look at the streams.
Am 03.08.2016 um 18:25 schrieb Richard Eckart de Castilho: > After a quick look, I think the loadBinary methods could be private. > > There seems to be a problem with stream handling. All methods that > internally create streams must make sure they are closed again. This > does e.g. not happen in the URL-based methods. There openStream() is > called in various places, but the stream is never closed. > > Mind that the stream should usually be closed in the same method that > creates it, not in a method that you pass the stream to. > > Best, > > -- Richard > >> On 03.08.2016, at 18:12, Peter Klügl <[email protected]> wrote: >> >> We can make them private, but I thought that maybe someone want to >> directly load a binary cas. Well that's not really necessary. >> >> >> Best, >> >> >> Peter >> >> >> Am 03.08.2016 um 18:10 schrieb Marshall Schor: >>> This class is a collection of static methods, mostly variants of "load" and >>> "save". >>> >>> There are 3 public methods "loadBinary" that appear to be called from >>> various >>> "load" methods. >>> >>> Could these loadBinary methods be changed to private, instead of public, or >>> do >>> they need to be part of the public API? >>> >>> -Marshall
