[ 
https://issues.apache.org/jira/browse/UIMA-5043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432815#comment-15432815
 ] 

Marshall Schor commented on UIMA-5043:
--------------------------------------

Just had a first look at the API for this, and have some slight concerns.

The UIMA Context is used for lots of things.  Therefore, I think the new API 
that uses this to get the settings from the external settings file should have 
a name that's a bit more specific than getSettings / getSettingsArray.  Perhaps 
something that mentions that the kind of settings being accessed are the 
external configuration parameters?  getExternalConfigSetting?  
getExternalConfigurationSetting?

Also, the return type for the method returning all the names perhaps should be 
a Collection, rather than a Set, to allow for more future flexibility in how 
this API is implemented, because I don't see the use case where a user of this 
API will be wanting/needing the "set" capabilies?

> Provide method to access individual external override settings
> --------------------------------------------------------------
>
>                 Key: UIMA-5043
>                 URL: https://issues.apache.org/jira/browse/UIMA-5043
>             Project: UIMA
>          Issue Type: Improvement
>          Components: Core Java Framework
>            Reporter: Burn Lewis
>            Assignee: Burn Lewis
>            Priority: Minor
>             Fix For: 2.9.0SDK
>
>
> The framework loads the external override settings and uses them in any 
> configuration parameter that has an external override name attached,  Users 
> have asked for the ability to access these values directly without the 
> indirection of configuration parameter entries in descriptors.  Currently the 
> complete Settings object that holds all the external override settings loaded 
> by the framework is accessible via UimaContextAdmin.
> An improvement would be to allow individual values to be read using a method 
> in the UimaContext interface, perhaps: 
> String getExternalOverride(String name)
> String[] getExternalOverrideArray{String name)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to