Hi,
It seems incremental to me (though a big increment). And backwards
compatible. Less effort than a complete parser rewrite. (really, all
you're doing is having DirectiveArg() call Expression() instead of
StringLiteral(), IntegerLiteral(), etc).
I've got other things I'm interested in first, so this is all long
term and may very wait until we have a new parser as Henning proposes.
WILL
On 3/24/07, Henning P. Schmiedehausen <[EMAIL PROTECTED]> wrote:
"Will Glass-Husain" <[EMAIL PROTECTED]> writes:
This is IMHO a major rewrite of the parser. If we go that way, then I
would strongy lobby for a fully plugable solution. For web related
stuff, it would be nice to be able to swap something JSTL compatible
in. Also getting OGNL support would be nice.
Does not sound like 1.x material to me, but I could be wrong here.
Best regards
Henning
>I thought there was a JIRA issue on this, but I was mistaken.
>I was thinking it'd be nice to support
>#someMacro (10 + 10)
>but I don't feel strongly about it.
>Actually, on a related topic, I'd really like to see us add syntax for
>expressions in method calls. I do this all the time (generating a
>syntax error).
>$Tool.someMethod($velocityCount - 1)
>or similar.
>WILL
>On 3/24/07, Nathan Bubna <[EMAIL PROTECTED]> wrote:
>> On 3/24/07, Supun Kamburugamuva <[EMAIL PROTECTED]> wrote:
>> > Hi,
>> > Thanks for the feedback. I'll add those additions and corrections.
>> >
>> > I think adding the capability to pass expressions to macros make them
>> > more complete. So I'll stick to my orginal proposal.
>>
>> I still don't know what this refers to. Will? I understand this was
>> your suggestion? What sort of expressions are you talking about?
>>
>> > Thanks,
>> > Supun..
>> >
>> > On 3/23/07, Will Glass-Husain <[EMAIL PROTECTED]> wrote:
>> > > Supun,
>> > >
>> > > Really a very nice proposal. I think it'd be helpful to link at the
>> > > end a list of relevant JIRA issues and wiki pages. It looks like
>> > > (among other things) you are referring to
>> > > http://wiki.apache.org/velocity/MacroIssues
>> > >
>> > > You list 'All the improvements to the code should not destroy the
>> > > backward compatibility of the Velocity engine, and it shouldn't affect
>> > > the Velocity engines template caching mechanism. These are two
>> > > challenging issues that need to be addressed with care'
>> > >
>> > > I want to suggest a third requirement, which is that performance
>> > > should not be significantly affected. This is really related to the
>> > > caching issue.
>> > >
>> > > I think the "allow expressions in macro arguments" idea is nice, but
>> > > not essential. (yes, I know this was my suggestion). Nathan's point
>> > > about macro bodies might be more relevant. But I encourage you to
>> > > follow your interests here.
>> > >
>> > > Best, WILL
>> > >
>> > > On 3/23/07, Supun Kamburugamuva <[EMAIL PROTECTED]> wrote:
>> > > > Hi,
>> > > >
>> > > > Thanks for the effort. I have corrected most of the spelling issues
>> > > > and grammatical issues. If you have time please go thought it.
>> > > >
>> > > > Thanks,
>> > > > Supun..
>> > > >
>> > > > On 3/22/07, Nathan Bubna <[EMAIL PROTECTED]> wrote:
>> > > > > There are some grammatical/spelling issues*, but on the whole it
looks
>> > > > > good to me.
>> > > > >
>> > > > > *On spelling, change "cashing" to "caching". If you want grammar
>> > > > > corrections let me know, and i can go through it again and send you a
>> > > > > list later today.
>> > > > >
>> > > > > On 3/21/07, Supun Kamburugamuva <[EMAIL PROTECTED]> wrote:
>> > > > > > Hi,
>> > > > > > I have almost completed my proposal for Veocimacro improvements.
It is
>> > > > > > in http://wiki.apache.org/general/GSOC2007/Supun/Velocimacro.
>> > > > > > I'd really appreciate, if anyone can look in to that. I'm pretty
sure
>> > > > > > there are lot of things that can be improved.
>> > > > > >
>> > > > > > Thanks,
>> > > > > > Supun Kamburugamuva.
>> > > > > >
>> > > > > > On 3/18/07, Will Glass-Husain <[EMAIL PROTECTED]> wrote:
>> > > > > > > Interesting idea. We need to be sure the scope is broad enough
for a
>> > > > > > > full GSOC project. For more info, I've been browsing
>> > > > > > > http://wiki.apache.org/general/SummerOfCode2007
>> > > > > > >
>> > > > > > > I'll write up both of these ideas and add them to the list,
putting my
>> > > > > > > name down as mentor. If anyone else is interesting I'd be happy
to
>> > > > > > > have company. Supun, if you're interested you'll have to
develop a
>> > > > > > > detailed application. If you post your application to the list
ahead
>> > > > > > > of time (before the deadline) we can help you refine it.
>> > > > > > >
>> > > > > > > WILL
>> > > > > > >
>> > > > > > > On 3/17/07, Malcolm Edgar <[EMAIL PROTECTED]> wrote:
>> > > > > > > > +1 on the Performance project. There are some great tools for
>> > > > > > > > profiling applications now with open source licenses.
>> > > > > > > >
>> > > > > > > > As a student, you also will learn a great deal from this
project. The
>> > > > > > > > things you learn from profiling are very interesting, having
been
>> > > > > > > > involved in a 2 month project performance optimisation on a CRM
>> > > > > > > > system, it was one of the best development learning
experiences I have
>> > > > > > > > had.
>> > > > > > > >
>> > > > > > > > regards Malcolm Edgar
>> > > > > > > > http://click.sourceforge.net
>> > > > > > > >
>> > > > > > > > On 3/16/07, Ahmed Mohombe <[EMAIL PROTECTED]> wrote:
>> > > > > > > > > > Ideas from the community?
>> > > > > > > > > What about some *real* performance improvements?
>> > > > > > > > >
>> > > > > > > > > 4 years ago, when Velocity gained a big number of users, it
was because Velocity
>> > > > > > > > > was much faster than JSP.
>> > > > > > > > >
>> > > > > > > > > This is not true anymore, as JSP is much faster and scalable
now.
>> > > > > > > > >
>> > > > > > > > > Maybe it would be the time to try to regain a part of your users
with a "Performance Improvements
>> > > > > > > > > Project".
>> > > > > > > > >
>> > > > > > > > > Of course, it doesn't sounds spectacular, but the effect
would be one for sure :).
>> > > > > > > > >
>> > > > > > > > > Velocity needs really almost no new features(except better
error reporting and whitespace control),
>> > > > > > > > > but better speed is always good.
>> > > > > > > > >
>> > > > > > > > >
>> > > > > > > > > Ahmed.
>> > > > > > > > > P.S. I don't expect Velocity to be again faster than JSP (it
was up to 5 times faster in the past),
>> > > > > > > > > but now the situation is almost reversed, so reducing the
gap a little would be great.
>> > > > > > > > >
>> > > > > > > > >
>> > > > > > > > >
---------------------------------------------------------------------
>> > > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > > > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
>> > > > > > > > >
>> > > > > > > > >
>> > > > > > > >
>> > > > > > > >
---------------------------------------------------------------------
>> > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
>> > > > > > > >
>> > > > > > > >
>> > > > > > >
>> > > > > > >
>> > > > > > > --
>> > > > > > > Forio Business Simulations
>> > > > > > >
>> > > > > > > Will Glass-Husain
>> > > > > > > [EMAIL PROTECTED]
>> > > > > > > www.forio.com
>> > > > > > >
>> > > > > > >
---------------------------------------------------------------------
>> > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
>> > > > > > >
>> > > > > > >
>> > > > > >
>> > > > > >
---------------------------------------------------------------------
>> > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
>> > > > > >
>> > > > > >
>> > > > >
>> > > > > ---------------------------------------------------------------------
>> > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > > > For additional commands, e-mail: [EMAIL PROTECTED]
>> > > > >
>> > > > >
>> > > >
>> > > > ---------------------------------------------------------------------
>> > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > > For additional commands, e-mail: [EMAIL PROTECTED]
>> > > >
>> > > >
>> > >
>> > >
>> > > --
>> > > Forio Business Simulations
>> > >
>> > > Will Glass-Husain
>> > > [EMAIL PROTECTED]
>> > > www.forio.com
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > > For additional commands, e-mail: [EMAIL PROTECTED]
>> > >
>> > >
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: [EMAIL PROTECTED]
>> > For additional commands, e-mail: [EMAIL PROTECTED]
>> >
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>>
>>
>--
>Forio Business Simulations
>Will Glass-Husain
>[EMAIL PROTECTED]
>www.forio.com
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
--
Henning P. Schmiedehausen -- [EMAIL PROTECTED] | J2EE, Linux,
|gls
91054 Buckenhof, Germany -- +49 9131 506540 | Apache person |eau
Open Source Consulting, Development, Design | Velocity - Turbine guy |rwc
|m k
INTERMETA - Gesellschaft fuer Mehrwertdienste mbH - RG Fuerth, HRB 7350 |a s
Sitz der Gesellschaft: Buckenhof. Geschaeftsfuehrer: Henning Schmiedehausen |n
"Save the cheerleader. Save the world."
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Forio Business Simulations
Will Glass-Husain
[EMAIL PROTECTED]
www.forio.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
