Cool, things have improved; i only found two more clear grammar problems:

- In the "Project Details" section, the start of the last sentence in
the third paragraph needs to change from "If the values is True" to
"If the value is True".

- In the third sentence of the "Maximum recursive depths" paragraph,
"use property" should be "use a property".

Also, i have a few technical comments that i did not think of before.
In the "Argument overloading" section of the "Project details", it is
not clear whether you intend to change it so users can define multiple
macros with the same name but different argument types (so arguments
are passed by value) or whether you simply intend to allow users to
define multiple macros with the same name but which accept different
numbers of arguments (which would still be passed by name).   You may
consider clarifying that paragraph to clearly mean that latter option,
as that is the desired feature, while the former is definitely not
wanted.

I'm also not entirely clear what the "Passing expressions as
arguments" section is about. Is there a JIRA issue or Wiki entry about
this that you can point to as a reference for me to understand this?
What sort expressions are you concerned with?  You already can do
things like #fooMacro( $this.is.anExpression() ).

Finally, one very common feature request for Velocimacros that would
be very appreciated, is to allow users to define Velocimacros that
take bodies.  So i could do something like

#macro( toDiv $class )
<div class="$class">#body</div>
#end

and use it like:

#toDiv( 'foo' )This is the body.#end

to produce

<div class="foo">This is the body.</div>

If you were interested in working on this feature, you'd be my hero!
Of course, that's your decision... :)


On 3/23/07, Supun Kamburugamuva <[EMAIL PROTECTED]> wrote:
Hi,

Thanks for the effort. I have corrected most of the spelling issues
and grammatical issues. If you have time please go thought it.

Thanks,
Supun..

On 3/22/07, Nathan Bubna <[EMAIL PROTECTED]> wrote:
> There are some grammatical/spelling issues*, but on the whole it looks
> good to me.
>
> *On spelling, change "cashing" to "caching".  If you want grammar
> corrections let me know, and i can go through it again and send you a
> list later today.
>
> On 3/21/07, Supun Kamburugamuva <[EMAIL PROTECTED]> wrote:
> > Hi,
> > I have almost completed my proposal for Veocimacro improvements. It is
> > in  http://wiki.apache.org/general/GSOC2007/Supun/Velocimacro.
> > I'd really appreciate, if anyone can look in to that. I'm pretty sure
> > there are lot of things that can be improved.
> >
> > Thanks,
> > Supun Kamburugamuva.
> >
> > On 3/18/07, Will Glass-Husain <[EMAIL PROTECTED]> wrote:
> > > Interesting idea.  We need to be sure the scope is broad enough for a
> > > full GSOC project.  For more info, I've been browsing
> > > http://wiki.apache.org/general/SummerOfCode2007
> > >
> > > I'll write up both of these ideas and add them to the list, putting my
> > > name down as mentor.  If anyone else is interesting I'd be happy to
> > > have company.  Supun, if you're interested you'll have to develop a
> > > detailed application.  If you post your application to the list ahead
> > > of time (before the deadline) we can help you refine it.
> > >
> > > WILL
> > >
> > > On 3/17/07, Malcolm Edgar <[EMAIL PROTECTED]> wrote:
> > > > +1 on the Performance project.  There are some great tools for
> > > > profiling applications now with open source licenses.
> > > >
> > > > As a student, you also will learn a great deal from this project. The
> > > > things you learn from profiling are very interesting, having been
> > > > involved in a 2 month project performance optimisation on a CRM
> > > > system, it was one of the best development learning experiences I have
> > > > had.
> > > >
> > > > regards Malcolm Edgar
> > > > http://click.sourceforge.net
> > > >
> > > > On 3/16/07, Ahmed Mohombe <[EMAIL PROTECTED]> wrote:
> > > > > > Ideas from the community?
> > > > > What about some *real* performance improvements?
> > > > >
> > > > > 4 years ago, when Velocity gained a big number of users, it was 
because Velocity
> > > > > was much faster than JSP.
> > > > >
> > > > > This is not true anymore, as JSP is much faster and scalable now.
> > > > >
> > > > > Maybe it would be the time to try to regain a part of your users with a 
"Performance Improvements
> > > > > Project".
> > > > >
> > > > > Of course, it doesn't sounds spectacular, but the effect would be one 
for sure :).
> > > > >
> > > > > Velocity needs really almost no new features(except better error 
reporting and whitespace control),
> > > > > but better speed is always good.
> > > > >
> > > > >
> > > > > Ahmed.
> > > > > P.S. I don't expect Velocity to be again faster than JSP (it was up 
to 5 times faster in the past),
> > > > > but now the situation is almost reversed, so reducing the gap a 
little would be great.
> > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > >
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > >
> > > >
> > >
> > >
> > > --
> > > Forio Business Simulations
> > >
> > > Will Glass-Husain
> > > [EMAIL PROTECTED]
> > > www.forio.com
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to