Claude, I have tested the fix and it now works, thanks.
## One thing now is I cannot get the log into debug mode. I use commons-logging with log4j and the log4j-slf4j-impl as a bridge. <logger name="org.apache.velocity" level="DEBUG" additivity="false"> <appender-ref ref="RollingFile" /> </logger> Other jars that use slf4j will log to debug ok. The notes mention runtime.log.instance= maybe I need to set something here? On 9 November 2016 at 22:40, Claude Brisson <cla...@renegat.net> wrote: > Thanks Nathan! > > Greg, the bug is fixed. But I'll wait at least 48h for potential more > feedback (thanks, by the way!) before submitting a new release candidate. > > If you want to test the corrected version before, you can grab the latest > snapshot here: > > https://repository.apache.org/content/repositories/snapshots > /org/apache/velocity/velocity-engine-core/2.0-SNAPSHOT/ > velocity-engine-core-2.0-20161109.221234-5.jar > > (with the usual signatures in .sha1 and .md5 files). > > Claude > > > On 09/11/2016 18:45, Nathan Bubna wrote: > >> Gah, really wish i had time to help. Keep up the great work, Claude! >> >> On Wed, Nov 9, 2016 at 9:06 AM, Claude Brisson <cla...@renegat.net> >> wrote: >> >> Ok, I reproduced it. It happens when the method is overloaded with a >>> variant that takes no argument. >>> >>> Guess there will be a third release candidate... >>> >>> >>> >>> On 09/11/2016 17:44, Greg Huber wrote: >>> >>> It seems to be returning the wrong class name in ClassUtils >>>> >>>> method = node.getRuntimeServices().getUberspect().getMethod(o, >>>> methodName, >>>> params, >>>> new Info(node.getTemplateName(), node.getLine(), >>>> node.getColumn())); >>>> >>>> It is returning a method name of .thumbResource() rather than >>>> .thumbResource(String, String) and then further down the java reflection >>>> throws the java.lang.IllegalArgumentException exception. >>>> >>>> >>>> On 9 November 2016 at 16:09, Claude Brisson <cla...@renegat.net> wrote: >>>> >>>> I cannot reproduce it. >>>> >>>>> Is the thumbResource() method overloaded? >>>>> >>>>> Do you have the full stacktrace? >>>>> >>>>> >>>>> On 09/11/2016 16:50, Greg Huber wrote: >>>>> >>>>> Hello, >>>>> >>>>>> I am getting an error when a parameter on a method name is null, it >>>>>> says >>>>>> "wrong number of arguments at" >>>>>> >>>>>> eg : >>>>>> >>>>>> $entry.filePath == null >>>>>> >>>>>> $myPojo.thumbResource($entry.name, $entry.filePath) >>>>>> >>>>>> I get an exception : >>>>>> >>>>>> java.lang.IllegalArgumentException: wrong number of arguments at.. >>>>>> >>>>>> >>>>>> >>>>>> public String thumbResource(String name, String filePath) { >>>>>> ... >>>>>> } >>>>>> >>>>>> I have tried to debug it but it seems to originate in the ASTMethod >>>>>> class. >>>>>> If i change the variable to be blanks it works ok. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On 9 November 2016 at 14:50, Claude Brisson <cla...@renegat.net> >>>>>> wrote: >>>>>> >>>>>> A new test build of Velocity Engine 2.0 is available. >>>>>> >>>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of >>>>>>> Velocity >>>>>>> Engine 2.0 has been made, and at this time it is simply a "test >>>>>>> build". >>>>>>> We >>>>>>> welcome any comments you may have, and will take all feedback into >>>>>>> account >>>>>>> if a quality vote is called for this build. >>>>>>> >>>>>>> Release notes: >>>>>>> >>>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng >>>>>>> ine/2.0/release-notes.html >>>>>>> >>>>>>> Distribution: >>>>>>> >>>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng >>>>>>> ine/2.0/ >>>>>>> >>>>>>> Maven 2 staging repository: >>>>>>> >>>>>>> * https://repository.apache.org/content/repositories/orgapache >>>>>>> velocity-1011/ >>>>>>> >>>>>>> A vote regarding the quality of this test build will be initiated >>>>>>> within >>>>>>> the next couple of days. >>>>>>> >>>>>>> >>>>>>> Regards, >>>>>>> >>>>>>> Claude >>>>>>> >>>>>>> >>>>>>> On 07/11/2016 11:06, Claude Brisson wrote: >>>>>>> >>>>>>> The test build of Velocity Engine 2.0 is available. >>>>>>> >>>>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of >>>>>>>> Velocity >>>>>>>> Engine 2.0 has been made, and at this time it is simply a "test >>>>>>>> build". >>>>>>>> We >>>>>>>> welcome any comments you may have, and will take all feedback into >>>>>>>> account >>>>>>>> if a quality vote is called for this build. >>>>>>>> >>>>>>>> Release notes: >>>>>>>> >>>>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng >>>>>>>> ine/2.0/release-notes.html >>>>>>>> >>>>>>>> Distribution: >>>>>>>> >>>>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng >>>>>>>> ine/2.0/ >>>>>>>> >>>>>>>> Maven 2 staging repository: >>>>>>>> >>>>>>>> * https://repository.apache.org/content/repositories/orgapache >>>>>>>> velocity-1010/ >>>>>>>> >>>>>>>> A vote regarding the quality of this test build will be initiated >>>>>>>> within >>>>>>>> the next couple of days. >>>>>>>> >>>>>>>> >>>>>>>> Regards, >>>>>>>> >>>>>>>> Claude >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ------------------------------------------------------------ >>>>>>>> --------- >>>>>>>> >>>>>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org >>>>> For additional commands, e-mail: dev-h...@velocity.apache.org >>>>> >>>>> >>>>> >>>>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org >>> For additional commands, e-mail: dev-h...@velocity.apache.org >>> >>> >>> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org > For additional commands, e-mail: dev-h...@velocity.apache.org > >
