Hi,All: I think it's necessary to describe how you refactor the slidercompnonent in more detail and which method you used to improve slider. About compatible,if WXRecycleSliderComponent support all the old slider api and it can run all the test case successfully . I think it no need to maintain two copies code to finish one component. it is more difficult to maintain. is it better to change WXRecycleSliderComponent to WXSliderComponent?
Best Regards Jerry > 在 2017年4月5日，上午11:51，Adam Feng <cxfe...@gmail.com <mailto:cxfe...@gmail.com>> > 写道： > > I suppose it’s a good start point. “slider” component has too much > complicated and deprecated logic which has made it hard to maintain. > > For a clearer code review, we need more detailed information for this PR, > for example, why is the old slider difficult to understand? What is done to > make the new slider clear and easy to maintain? > > And to be compatible, I suggest to use another tag name for the new slider > component, for the old component is being used by too many users, if the > new slider component has some bugs, it’s hart to roll back. > > Finally, test cases must be added for the new component. > > Thanks. > Adam Feng > > On 2017年4月5日 +0800 AM11:47, 刘洪峰(孤剑) <hongfeng....@alibaba-inc.com > <mailto:hongfeng....@alibaba-inc.com>>, wrote: >> Hi,All: >> I wrote a new slider component which is named WXRecycleSliderComponent to >> replace the old slider component which is named WXSliderComponent.(PR: >> https://github.com/apache/incubator-weex/pull/210 >> <https://github.com/apache/incubator-weex/pull/210>) >> The logic of old slider component is difficult to understand, and there are >> a lot of bugs. The new slider component’s line is reduced by a quarter, >> logic is clear and easy to maintain. So I create a pull request to replace >> the WXSliderComponent by my new WXRecycleSliderComponent. >> You can use the following demos to test: >> .we demo: http://dotwe.org/weex/6c4b4a98f6d17c8b84d278fe2d0b8cb1 >> <http://dotwe.org/weex/6c4b4a98f6d17c8b84d278fe2d0b8cb1> >> .vue demo: http://dotwe.org/vue/9542e460d868e211ad2463e648a80cef >> <http://dotwe.org/vue/9542e460d868e211ad2463e648a80cef> >> weex playgrournd demo. >> >> --bluebird78999 >> Thank you for your support. >> >> 在 2017/4/5 上午11:05，“bluebird78999”<g...@git.apache.org >> <mailto:g...@git.apache.org>> 写入: >> >>> GitHub user bluebird78999 opened a pull request: >>> >>> https://github.com/apache/incubator-weex/pull/210 >>> <https://github.com/apache/incubator-weex/pull/210> >>> >>> * [ios] the new slider component which is named WXRecycleSliderCompon >>> >>> [ios] the new slider component which is named WXRecycleSliderComponent to >>> replace the old slider component which is name WXSliderComponent. >>> <!-- >>> >>> Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017. >>> >>> Our new GitHub repo is https://github.com/apache/incubator-weex >>> >>> After Feb 24 2017, we only accept pull requests from >>> https://github.com/apache/incubator-weex >>> >>> Thank you for your support. >>> >>> ---- >>> >>> 擨æ≥∂ïπ˚Weex å°∫äº⁄ 2017-02-24 这移èΩ“ Apache 僺éΩŒäπ˚ >>> >>> 居昶æ√Œä»¬äπ˚ä∏¿ç‰¨æˆ°ç˚≥ GitHub >>> 仄庄ïπ˚https://github.com/apache/incubator-weex >>> <https://github.com/apache/incubator-weex> >>> å’¶å˛¨é≠£éΩ‘ç»§ç»–æ⁄¥å∂˜å€§å®¶ç˚≥ pull requestã•≠ >>> >>> æ˝´å€˚诜æ∞∑请å∑“擨ïπ˚https://github.com/weexteam/article/issues/130 >>> <https://github.com/weexteam/article/issues/130> >>> >>> æ≥ƒè°¢ç∆∫解傑扯摙 >>> >>> -- >>> >>> <!-- >>> >>> It's ***RECOMMENDED*** to submit typo fix, new demo and tiny bugfix to >>> `dev` branch. New feature and other modifications can be submitted to >>> "domain" branch including `ios`, `android`, `jsfm`, `html5`. >>> >>> See [Branch >>> Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management >>> >>> <https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management>) >>> for more detail. >>> >>> ---- >>> >>> ïπ√è¯·å˛¨***æ∂∆亀***å≈Ÿå√ é˙€è¿˙段æ∂∂è¿°ïπ≈ >>> >>> é‰˙å√«å–˜ä¿®æ‰’㕙戰 demoã•™è≤∞å°∂ç˚≥ bugfix é∞∏å∂¯ä»¥ç˝´æ⁄¥æ∂∆å√° `dev` >>> å√∫扯ïπ˝æˆ°é˛•æ±≠以å∂…ä»»ä∏ä∏ >>> 丟确å®˚å∏±å„Ÿéˇ¢ç˚≥扒全ïπ‘请æ∂∆亀å√°å¯’åº‰â•˛é¢∫åƒƒâ•ˇç˚≥å√∫扯ïπ√`ios`ã•™`android`ã•™`jsfm`ã•™`html5`ïπ≈ã•≠ >>> >>> æƒ¥ç˛—å®‘æ´ç˚≥[å√∫æ‰¯ç–ˆç¥ >>> (è—±æˆΩ)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management >>> >>> <https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management>)ã•≠ >>> >>> -- >>> >>> >>> You can merge this pull request into a Git repository by running: >>> >>> $ git pull https://github.com/bluebird78999/incubator-weex >>> 0.12-dev-newSlider >>> >>> Alternatively you can review and apply these changes as the patch at: >>> >>> https://github.com/apache/incubator-weex/pull/210.patch >>> >>> To close this pull request, make a commit to your master/trunk branch >>> with (at least) the following in the commit message: >>> >>> This closes #210 >>> >>> ---- >>> commit b7bcdb1ccd807ee1e17e54de124dedf77746f022 >>> Author: LiuHongfeng(GuJian) <larrywork...@gmail.com >>> Date: 2017-04-05T03:00:00Z >>> >>> * [ios] the new slider component which is named WXRecycleSliderComponent to >>> replace the old slider component which is name WXSliderComponent. >>> >>> ---- >>> >>> >>> --- >>> If your project is set up for it, you can reply to this email and have your >>> reply appear on GitHub as well. If your project does not have this feature >>> enabled and wishes so, or if the feature is enabled but not working, please >>> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket >>> with INFRA. >>> ---
smime.p7s
Description: S/MIME cryptographic signature
