I have to say that mail clients do mess up email addresses, so I'll double 
check this one.

The error message would indicate that the @from variable is actually empty:

Warning: Invalid From address ''


The actual @from email address in the message-to-be-sent is:

Craig L Russell <[email protected]>

I dunno where the non-email-address [email protected] came from. Not from 
anything I wrote I hope.

So we need to look at the @from variable.

And also figure out why this check is necessary, since there is no similar 
check in other document filing code (ccla, grant, emeritus).

Craig

> On Feb 10, 2021, at 5:14 PM, sebb <[email protected]> wrote:
> 
> The error message suggests that the @from variable is empty, so no
> wonder the RE fails.
> 
> On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding <[email protected]> wrote:
>> 
>> Wow, Apple Mail really messed that up by adding mailto links everywhere. 
>> What I meant was
>> 
>>    you should also note that \w excludes hyphen and ".", so 
>> [email protected]
>>    will not match regardless. You need [\w\+\=\.\-][email protected] (or 
>> something), or
>>    just check the end with /\@apache\.org>?$/
> 
> I don't think [email protected] is currently possible as an ASF
> email, but point taken, the RE could be a bit less strict.
> 
> However, given that @from appears to be empty, I wonder if it is necessary.
> This needs to be checked.
> 
>> ....Roy
>> 

Craig L Russell
[email protected]

Reply via email to