Hi Sebb, Your patch seems to have fixed the problem.
The only remaining question for me is whether the validity of the @from variable should be in any other document processing tasks (ccla, grant, emeritus). Thanks, Craig > On Feb 11, 2021, at 4:44 AM, sebb <[email protected]> wrote: > > On Thu, 11 Feb 2021 at 02:10, Craig Russell <[email protected] > <mailto:[email protected]>> wrote: >> >> I have to say that mail clients do mess up email addresses, so I'll double >> check this one. >> >> The error message would indicate that the @from variable is actually empty: >> >> Warning: Invalid From address '' >> >> >> The actual @from email address in the message-to-be-sent is: >> >> Craig L Russell <[email protected]> >> >> I dunno where the non-email-address [email protected] came from. Not >> from anything I wrote I hope. >> >> So we need to look at the @from variable. > > It appears to be empty at the point where it is checked, whereas it is > set where it is used to create the message around line 133 in > icla.json.rb > It is not updated anywhere in that file, so I assume var must be part > of the context established by the 'task' block. > >> And also figure out why this check is necessary, since there is no similar >> check in other document filing code (ccla, grant, emeritus). > > The check was added a long time ago in the form of a taint check. > This was converted into a warning when Ruby taint was deprecated. > > Whether the check is needed depends on whether the variable value can > be misused to cause a problem. > I have moved the check to the task block. > > If it continues to cause an issue, we can investigate whether it can > safely be dropped. > >> Craig >> >>> On Feb 10, 2021, at 5:14 PM, sebb <[email protected]> wrote: >>> >>> The error message suggests that the @from variable is empty, so no >>> wonder the RE fails. >>> >>> On Wed, 10 Feb 2021 at 18:08, Roy T. Fielding <[email protected]> wrote: >>>> >>>> Wow, Apple Mail really messed that up by adding mailto links everywhere. >>>> What I meant was >>>> >>>> you should also note that \w excludes hyphen and ".", so >>>> [email protected] >>>> will not match regardless. You need [\w\+\=\.\-][email protected] (or >>>> something), or >>>> just check the end with /\@apache\.org>?$/ >>> >>> I don't think [email protected] is currently possible as an ASF >>> email, but point taken, the RE could be a bit less strict. >>> >>> However, given that @from appears to be empty, I wonder if it is necessary. >>> This needs to be checked. >>> >>>> ....Roy >>>> >> >> Craig L Russell >> [email protected] Craig L Russell [email protected]
