There are also a lot of things that are just perfectly fine..
Suspicious system array call (we know that it is an array.. Does it
want an extra cast??)
Or the one from FormComponent.getInputname() equals between string an
prepending.. Thats also not a problem because prepending is really
content equal (so the same 'string' as a string or a prepending is
just true)
On 12/23/07, C. Bergström <[EMAIL PROTECTED]> wrote:
> I ran inspection against the wicket trunk (Revision: 606531) and maybe
> interesting to someone else as well.. It covers a lot... including
> superfluous things such as the html, css, javascript, naming
> conventions.. This is with default settings, but if anyone wants I can
> rerun and include/exclude more items.. (unchecking the html, but
> including potential memory issues..)
>
> Of course there are false positives..
> ------
> archtypes/quickstart...
> package ${packageName};
> ------
>
> It's temporarily available at
> http://www.netsyncro.com/downloads/wicket-inspection.tar.bz2
> (Warning 1.7M download, but extracts out to 144M)
>
> Alternatively, you can browse it.
> http://www.netsyncro.com/downloads/inspection/index.html
>
> I don't mind making up a patch, but I can't commit.
>
> If you want to reproduce this..
> Download IDEA
> http://www.jetbrains.net/confluence/display/IDEADEV/Selena+EAP
>
> 1) Checkout a new project from svn
> 2) Create a new project from that using maven (should be self
> explanatory)
> 3) Analyze > inspect code
>
> For some/most of the items you'll have the option to refactor a fix.
>
> Seasonal greetings!
>
> ./C
>
>
