-1:
 - validation of the archive works, but there is no public key in KEYS
[1] to verify that the fingerprint matches our Igor.
 - no release tag in http://svn.apache.org/repos/asf/wicket/tags/wicket-1.3.6
 - no release branch (with modified poms) in
http://svn.apache.org/repos/asf/wicket/releases/wicket-1.3.6

^^^ these can be easily fixed without having to re-roll the release artifacts

-0:
 - no rat report generated (I've ran rat, and didn't uncover any odd
discrepancies, other than:
 - .tomcatplugin, .amateras and velocity.log files are in the distribution

Did you create the Java 1.4 jars using a 1.4 JDK? (hard to guess from
the manifest, as maven overwrites previously generated jar files when
performing the release)

If I run mvn5 install on our src distribution and after that a mvn4
install, I get the following test failures:
  
testThousandSeperator(org.apache.wicket.util.convert.converters.ConvertersTest)
  
testParentEscapeSequenceInRenderedHtml(org.apache.wicket.ParentResourceEscapePathTest)
  
testResourceUrlGeneratedByResourceReference(org.apache.wicket.ParentResourceEscapePathTest)
  
testRequestHandlingOfResourceUrlWithEscapeStringInside(org.apache.wicket.ParentResourceEscapePathTest)

Which are due to wrong bindings. If you did use 1.4 to compile the
JDK-1.4 jars, then there's no problem, but if you used JDK 1.5 (or
newer) then we need to roll the release again.

Martijn

[1] http://svn.apache.org/repos/asf/wicket/common/KEYS

Reply via email to