False alarm... this is my workspace messing up.
Martijn
On Mon, Apr 27, 2009 at 1:10 PM, Martijn Dashorst
<martijn.dasho...@gmail.com> wrote:
> Another weird thing: when looking at the locally generated JAR file
> from the release inside Eclipse I see the following:
>
> // Compiled from Session.java (version 1.4 : 48.0, super bit)
> public abstract class org.apache.wicket.Session implements
> org.apache.wicket.IClusterable,
> net.sourceforge.cobertura.coveragedata.HasBeenInstrumented {
>
> The cobertura stuff is unsettling IMO.
>
> Martijn
>
> On Mon, Apr 27, 2009 at 11:53 AM, Martijn Dashorst
> <martijn.dasho...@gmail.com> wrote:
>> -1:
>> - validation of the archive works, but there is no public key in KEYS
>> [1] to verify that the fingerprint matches our Igor.
>> - no release tag in http://svn.apache.org/repos/asf/wicket/tags/wicket-1.3.6
>> - no release branch (with modified poms) in
>> http://svn.apache.org/repos/asf/wicket/releases/wicket-1.3.6
>>
>> ^^^ these can be easily fixed without having to re-roll the release artifacts
>>
>> -0:
>> - no rat report generated (I've ran rat, and didn't uncover any odd
>> discrepancies, other than:
>> - .tomcatplugin, .amateras and velocity.log files are in the distribution
>>
>> Did you create the Java 1.4 jars using a 1.4 JDK? (hard to guess from
>> the manifest, as maven overwrites previously generated jar files when
>> performing the release)
>>
>> If I run mvn5 install on our src distribution and after that a mvn4
>> install, I get the following test failures:
>> testThousandSeperator(org.apache.wicket.util.convert.converters.ConvertersTest)
>> testParentEscapeSequenceInRenderedHtml(org.apache.wicket.ParentResourceEscapePathTest)
>> testResourceUrlGeneratedByResourceReference(org.apache.wicket.ParentResourceEscapePathTest)
>> testRequestHandlingOfResourceUrlWithEscapeStringInside(org.apache.wicket.ParentResourceEscapePathTest)
>>
>> Which are due to wrong bindings. If you did use 1.4 to compile the
>> JDK-1.4 jars, then there's no problem, but if you used JDK 1.5 (or
>> newer) then we need to roll the release again.
>>
>> Martijn
>>
>> [1] http://svn.apache.org/repos/asf/wicket/common/KEYS
>>
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
> Apache Wicket 1.3.5 is released
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Apache Wicket 1.3.5 is released
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.3.
