You're right, forgot about this option :).... So, if it will not be included in rc5, I will use a decorator as a workaround. Still, I hope it will be included :)
Thanks! Alex Objelean igor.vaynberg wrote: > >> Your suggestion, to override the WebRequestCodingStrategy isn't an >> option, >> just because WebRequestCodingStrategy#decode(Request) method is final. > > sure it is, webrequestcodingstrategy is an interface, if you cant > subclass then decorate. > > -igor > >> >> Thank you! >> Alex Objelean >> >> >> >> igor.vaynberg wrote: >>> >>> we should not fix this in 1.4, and there is already a jira for this in >>> 1.5. we should not fix it in 1.4 because there are existing production >>> sites that may depend on the current behavior and we should try not to >>> break them. the problem with this version is that due to various >>> reasons it got dragged out for quiet a while and there were production >>> sites running even on milestones because they were pretty stable. i >>> think we should just finish 1.4 and move on to 1.5 where we can fix >>> all these things. >>> >>> in the meanwhile users can always subclass the strategies, catch the >>> exceptions, and redirect to 404 if this is a big problem. >>> >>> -igor >>> >>> On Tue, Jun 2, 2009 at 10:25 PM, Alex Objelean <alex_objel...@yahoo.com> >>> wrote: >>>> >>>> Could it be fixed in wicket-1.4-rc5 release? >>>> >>>> Thanks! >>>> Alex Objelean >>>> >>>> >>>> Jeremy Thomerson-5 wrote: >>>>> >>>>> Sounds feasible to me. Definitely add a JIRA so that it gets tracked. >>>>> A patch will get it committed even sooner. >>>>> >>>>> -- >>>>> Jeremy Thomerson >>>>> http://www.wickettraining.com >>>>> >>>>> >>>>> >>>>> >>>>> On Wed, Jun 3, 2009 at 12:12 AM, Objelean Alex >>>>> <alex.objel...@gmail.com> >>>>> wrote: >>>>>> I know it may sound strange, but I have this request in my >>>>>> application: if user tweaks an url ending with "wicket:interface = >>>>>> :0::::" & add some kind of characters at the end, like "? or !", the >>>>>> page must be redirected to 404 instead of InternalError page. I know >>>>>> that I can catch WicketRuntimeException & redirect always to 404, but >>>>>> this would hide other potential problems because >>>>>> WicketRuntimeException can be caused by other types of problems. >>>>>> >>>>>> My suggestion is to throw a more specific RuntimeException in the >>>>>> WebRequestCodingStrategy.decode method, like DecodeRequestException >>>>>> (subclass of WicketRuntimeException). This way, I can treat only this >>>>>> kind of problems differently. >>>>>> >>>>>> What is you oppinion? Should I create a JIRA issue for that? >>>>>> >>>>>> Thank you! >>>>>> Alex Objelean >>>>>> >>>>> >>>>> >>>> >>>> -- >>>> View this message in context: >>>> http://www.nabble.com/-RFE--WebRequestCodingStrategy.decode-tp23845496p23845588.html >>>> Sent from the Wicket - Dev mailing list archive at Nabble.com. >>>> >>>> >>> >>> >> >> -- >> View this message in context: >> http://www.nabble.com/-RFE--WebRequestCodingStrategy.decode-tp23845496p23845652.html >> Sent from the Wicket - Dev mailing list archive at Nabble.com. >> >> > > -- View this message in context: http://www.nabble.com/-RFE--WebRequestCodingStrategy.decode-tp23845496p23845789.html Sent from the Wicket - Dev mailing list archive at Nabble.com.
