I agree - commit-hook-based formatting would be awful, for several reasons:
1 - formatting CAN break code (I know it doesn't usually, but can), but besides that, if I commit, what I worked on should be transmitted to the server and stored in the history - not some mutated version 2 - the statement that "everyone can format how he or she likes" is FALSE. If I check-in my 16-char tabulation file and you check in your 2-tab-per-tab-tabulation file, and both are transformed to three-spaces-two-commas-and-a-pipe formatting (yes, I'm making that stuff up).... when I check out my file, I get the re-formatted version, and so does two-tab guy. So NEITHER of us is working with the same format we like / checked in. -- Jeremy Thomerson http://wickettraining.com *Need a CMS for Wicket? Use Brix! http://brixcms.org* On Thu, Apr 7, 2011 at 2:16 PM, Martin Grigorov <mgrigo...@apache.org>wrote: > Are you sure ? > I have never used something like this but it sounds bad. > I commit something and then when I open the logs I see something different > (my change + some formatting). > This way the history is totally messed up. > > On Thu, Apr 7, 2011 at 6:19 PM, Peter Ertl <pe...@gmx.org> wrote: > > > +1 on commit-hook-based code formatting > > > > Am 07.04.2011 um 18:06 schrieb Hans Lesmeister 2: > > > > > > > > Martin Grigorov-4 wrote: > > >> > > >> On Thu, Apr 7, 2011 at 3:51 PM, Hans Lesmeister 2 < > > >> hans.lesmeis...@lessy-software.de> wrote: > > >> > > >>> IMHO Formatting should be done on commit. > > >>> > > >> > > >> I guess you don't follow your colleagues work using email > notifications. > > >> > > >> > > > > > > I am not sure if I know what you mean by that. With "on commit" I meant > > on > > > the server, in this case the Git-Server. That way everybody can format > > the > > > way he or she likes. > > > > > > ----- > > > -- > > > Regards, > > > Hans > > > > > > http://cantaa.de > > > > > > -- > > > View this message in context: > > > http://apache-wicket.1842946.n4.nabble.com/Wicketstuff-1-5-Code-formatting-tp3432552p3433858.html > > > Sent from the Forum for Wicket Core developers mailing list archive at > > Nabble.com. > > > > > > > -- > Martin Grigorov > jWeekend > Training, Consulting, Development > http://jWeekend.com <http://jweekend.com/> >
