Hi,

On Mon, Oct 28, 2013 at 10:17 AM, Emond Papegaaij <[email protected]
> wrote:

> Hi Bernard,
>
> I was not totally convinced of the solution, so I started a thread here,
> hoping to get some feedback. However, I did not get the feedback I wanted.
> Martijn did start a really good proposal to fix PageParameters the right
> way, but this issue got forgotten. I've rebased the wicket-4997 branch
> against wicket-6.x. If I get no objections here, I'll merge it back in this
> week.
>

I do have objections.

1) I prefer such changes that may affect the core functionality to go in
the non-stable branch first.
Since you do not test the voted releases with your applications I am
against merging it directly in 6.x

As one of the few people working on 7.x I prefer to debug any problems that
may occur with this change in my small applications instead of
 compromising the stable branch and my main/dailyjob application.

2) the second reason to be against is that the release of 6.12 is postponed
3 weeks without any indications when it will be cut.
I don't want something like this to be merged in 6.x this Thursday and 6.12
to be cut on the following day


>
> Best regards,
> Emond
>
>
> On Sat, Oct 26, 2013 at 2:10 AM, Bernard <[email protected]> wrote:
>
> > Hi,
> >
> > Emond has done a lot of work in August to fix this in the 6.x branch.
> > I am happy with it.
> >
> > Thanks,
> >
> > Bernard
> >
>

Reply via email to