In addition, I just realized there is a mismatch in the Palette ctors, about choicesModel:
ctor #1 final IModel<? extends Collection<T>> choicesModel ctor #2: final IModel<? extends Collection<? extends T>> choicesModel I guess the ctor #2 is the right one (which is the original one), due to type of choicesModel member and the #getChoices signature. If I have time, I will investigate a little bit further on the Palette component because it seems to have a weird behavior... (getting wrong model object, list of available choices emptied after submit... maybe a misuse or might be related to the usage of a simple ChoiceRenderer like new ChoiceRenderer<String>() or new ChoiceRenderer<Integer>()). I do not say it's a wicket 7 specific issue, I do not remember having ever used the palette actually... Best regards, Sebastien. On Mon, Dec 16, 2013 at 10:50 PM, Sebastien <[email protected]> wrote: > Hi Martin, > > On Mon, Dec 16, 2013 at 3:02 PM, Martin Grigorov <[email protected]>wrote: > >> Hi Sebastien, >> >> Can you please provide more details about the issues ? >> >> - I see no restrictions in DatePicker.java about the <input>'s type >> attribute >> > > Sorry, I meant the DateTextField: > > protected String[] getInputTypes() > { > return new String[] { "date", "datetime", "datetime-local", > "month", "time", "week" }; > } > > So, this is no allowed anymore to have a markup with input type="text" > whereas it was legal in wicket 6 > > >> >> - I see that with 6f0f633 the constructor of Pallete now accepts: >> IModel<? extends Collection<T>> model >> >> instead of >> >> IModel<? extends List<? extends T>> model >> >> > Right, this could leads to a compilation error. User will likely replace > Model.ofList(myList) to new ListModel<String>(myList) or new > CollectionModel<String>(myList) > Or for jewelers: new ListModel<>(myList) or new CollectionModel<>(myList) > > >> - There was a discussion to deprecate IPageLink long time ago but for some >> reason we missed to mark it as such >> I'll deprecate it in 6.x and fix the migration guide >> >> > Thanks :) > > Best regards, > Sebastien. >
