On Mon, Dec 16, 2013 at 11:50 PM, Sebastien <[email protected]> wrote:
> Hi Martin, > > On Mon, Dec 16, 2013 at 3:02 PM, Martin Grigorov <[email protected] > >wrote: > > > Hi Sebastien, > > > > Can you please provide more details about the issues ? > > > > - I see no restrictions in DatePicker.java about the <input>'s type > > attribute > > > > Sorry, I meant the DateTextField: > > protected String[] getInputTypes() > { > return new String[] { "date", "datetime", "datetime-local", > "month", "time", "week" }; > } > > So, this is no allowed anymore to have a markup with input type="text" > whereas it was legal in wicket 6 > This was a regression. I've added back "text" type as allowed. > > > > > > - I see that with 6f0f633 the constructor of Pallete now accepts: > > IModel<? extends Collection<T>> model > > > > instead of > > > > IModel<? extends List<? extends T>> model > > > > > Right, this could leads to a compilation error. User will likely replace > Model.ofList(myList) to new ListModel<String>(myList) or new > CollectionModel<String>(myList) > Or for jewelers: new ListModel<>(myList) or new CollectionModel<>(myList) > > @Sven: would you please check this ? It has been changed with https://issues.apache.org/jira/browse/WICKET-5352 Thanks! > > > - There was a discussion to deprecate IPageLink long time ago but for > some > > reason we missed to mark it as such > > I'll deprecate it in 6.x and fix the migration guide > > > > > Thanks :) > > Best regards, > Sebastien. >
