On Mon, 18 Aug 2014 13:30:03 +0200 Martin Grigorov <mgrigo...@apache.org> wrote:
> I don't like the whole idea of re-adding component. > Wizard is the only component in Wicket distro which fails > the > org.apache.wicket.core.util.objects.checker.OrphanComponentChecker. I > think only the data (i.e. the models) should be kept around and the > components should be re-created for every view of that data when this > is needed. For me Wizard component is a bad practice. I'm not convinced it is entirely bad, but I can see that it is at least not optimal. However, Wicket does not prohibit it and so I think we should make sure it doesn't break in surprising ways. That said, I don't want to conflate this with the problems of Wizard too much, because I still think we should have a complement to onRemove, whether we're looking at Wizard or not, just to be consistent. I had a chat with Martin on IRC, he had a very good idea on how to simplify onAddToPage to a more clearly defined onReAdd. Thank you Martin! I've pushed an update including tests to the WICKET-5677 branch. The much simpler implementation is now not much more than an else branch in Component#fireInitialize. If the component is already initialized, it doesn't call onInitialize, but rather onReAdd. This way we have a clear distinction between the two callbacks and we don't need a second tree traversal, since this just uses the one that is there for onInitialize already. Martin and everyone else, what do you think? Carl-Eric
