I've applied the changes you suggested, they seem to work nicely. Only in the WICKET-5677 branch based on 6.x so far, I'll cherry-pick it to master once we agree that we can integrate this.
Carl-Eric On Thu, 21 Aug 2014 23:30:45 +0200 Carl-Eric Menzel <[email protected]> wrote: > On Wed, 20 Aug 2014 15:26:45 +0300 > Martin Grigorov <[email protected]> wrote: > > > Carl-Eric, > > > > could you please re-format the related classes in wicket-6.x branch > > so all noise like > > https://github.com/apache/wicket/compare/wicket-6.x...WICKET-5677#diff-bfa8bce2a5e14af19e42011a5e2d4c68L4380 > > disappear ? > > Just open the same classes in wicket-6.x branch, format them, > > commit+push. Cherry-pick in master. > > Will do. > > > I've added a comment on one of the commits in GitHub but so far I > > don't received a notification about it. Did you receive a > > notification about > > https://github.com/apache/wicket/commit/4703c1ae1af91fdcca44e34edbeeb8bbaeb63b6c#commitcomment-7456068 > > ? > > I didn't get a notification. But I'll have a look. > > Carl-Eric
