Okay - I'm going to create a new pull request tomorrow afternoon! kind regards
Tobias > Am 18.02.2015 um 22:22 schrieb Martin Grigorov <[email protected]>: > > On Wed, Feb 18, 2015 at 11:14 PM, Tobias Soloschenko < > [email protected]> wrote: > >> Hi, >> >> thank you very much for the feedback! >> >> - I saw that you fixed the Home.html, already! Great! >> >> - does the issue with the video still exists? Then I'm going to >> investigate it tomorrow. > > I've fixed it. > > >> >> - What I'm also going to do tomorrow afternoon is to change the layout to >> vertical and add additional information. >> >> - I used the same videos for #1 and #3 but the implementation of the >> second one is done via source tag. Should I use a different video? I used >> the test video of w3 - it is only counting the time. > > Just add some text next to them to explain that they use different ways to > work. No need of different videos, I think. > > >> >> kind regards >> >> Tobias >> >>> Am 18.02.2015 um 21:48 schrieb Martin Grigorov <[email protected]>: >>> >>> Hi Tobias, >>> >>> Some feedback from me: >>> - the build was broken because of a non well-formed Home.html >>> - video.mp4 was not copied in target/classes/ and running the examples >> with >>> Jetty was failing with "resource not found" >>> - how the second video could be made working ? There is a short >> explanation >>> that the problem is CORS. I think it would be better if the videos are >>> shown vertically with some description about each of them. I.e. add >>> something explaining what we see in demo #1 and what is different in demo >>> #3. >>> >>> Thank you! >>> >>> Martin Grigorov >>> Wicket Training and Consulting >>> https://twitter.com/mtgrigorov >>> >>> On Wed, Feb 18, 2015 at 8:50 PM, Tobias Soloschenko < >>> [email protected]> wrote: >>> >>>> Hi all, >>>> >>>> i would like to invite you to play a bit with the upcoming functionality >>>> of the playback with video and audio - >>>> >>>> Link to PR: https://github.com/apache/wicket/pull/93 >>>> >>>> The methods are named based on their correspondent HTML5 attributes. >>>> >>>> Sven already suggested to put the MediaStreamingResourceReference >>>> functionality into the PackageResourceReference. >>>> >>>> Further suggestions are very welcome! :-) >>>> >>>> Also have a look at wicket-examples. >>>> >>>> kind regards >>>> >>>> Tobias >>
