Great Solution! +1! kind regards
Tobias > Am 10.06.2015 um 09:53 schrieb Martijn Dashorst <martijn.dasho...@gmail.com>: > > The toolchain I've added to the build is only for the release profile. > Normal use will not be dependent on the availability of JDK 6 (for > wicket 6) > > In the coming weeks I'll try to see how far we can get with the > animalsniffer maven plugin to ensure we don't use Java N+1 features in > a Java N branch. That would at least remove some worries about using > non-existing API and only detecting it at release time. > > Martijn > > >> On Wed, Jun 10, 2015 at 9:25 AM, Martin Grigorov <mgrigo...@apache.org> >> wrote: >> For me the build is as simple as: mvn6 clean install >> where 'mvn6' is a custom script that does: JAVA_HOME=$JAVA_6_HOME mvn $* >> >> the script also exports custom locale (bg_BG), but this is just to make >> sure that Wicket tests don't not assume something (e.g. that the Locale is >> always EN or DE, or it doesn't use some method that uses platform default >> locale). Can you do that in your Eclipse? ;-) >> >> Let's see how the toolchains setup will look like. I haven't tried it yet >> so I cannot speculate. >> >> All I know is that Mac users do not have (or do not wish to have) some JDK >> versions and this leads to some problems for them. >> I personally have jdk 1.5, 1.6, 7, 8 and 9 here. I guess this is the reason >> why I release Wicket 1.4.x/1.5.x from time to time - because I can! :-) >> >> Martin Grigorov >> Wicket Training and Consulting >> https://twitter.com/mtgrigorov >> >> On Wed, Jun 10, 2015 at 9:40 AM, Tobias Soloschenko < >> tobiassolosche...@googlemail.com> wrote: >> >>> Hi, >>> >>> well - a lot of manual steps to know before building wicket then. >>> (Assuming Eclipse / JDK 8): >>> >>> 1. Install marketplace plugin for maven-eclipse-settings >>> 2. Configure toolschain >>> 3. Disable clirr plugin >>> 4. Configure save actions, ... >>> >>> We have to update the contribution docs. >>> >>> kind regards >>> >>> Tobias >>> >>>> Am 10.06.2015 um 08:30 schrieb Martin Grigorov <mgrigo...@apache.org>: >>>> >>>> Hi, >>>> >>>> On Tue, Jun 9, 2015 at 6:32 PM, Tobias Soloschenko < >>>> tobiassolosche...@googlemail.com> wrote: >>>> >>>>> Ah I see - that's right. >>>>> >>>>> +1 for toolschain - but we need to ensure that the build keeps running >>> on >>>>> jdk > 6 for wicket-6.x (unit tests, etc.) and that toolschain does not >>>>> abort the build nor requires jdk 6 >>>> >>>> You can setup your ~/.m2/toolchains.xml to point to the same JDK for all >>>> versions. I.e. <jdkHome>/path/to/same/jdk</jdkHome> >>>> But you should never make an official release! All builds are for your >>> own >>>> consumption. >>>> >>>> >>>>> I personally don't want to install several jdks :-/ to apply and test >>>>> changes on wicket-6.x >>>> >>>> Then use Docker to build Wicket in isolation without polluting your OS :p >>>> >>>> >>>>> >>>>> Maybe we can use toolschain in test scope and do a dummy compile or >>>>> something like that. >>>> >>>> See above. >>>> >>>> >>>>> >>>>> kind regards >>>>> >>>>> Tobias >>>>> >>>>>>> Am 09.06.2015 um 16:55 schrieb Martijn Dashorst < >>>>>> martijn.dasho...@gmail.com>: >>>>>> >>>>>> No. String#isEmpty() for example is JDK 7 only. There are subtle API >>>>>> differences in the JDK between 6 and 7 (and 8) that warrant extreme >>>>>> caution trying to use a JDK N+1 for a JDK N compatible product. >>>>>> >>>>>> If this avenue fails, we can opt to use the animalsniffer plugin to >>>>>> detect wrong API usage, but that is a last resort. >>>>>> >>>>>> Martijn >>>>>> >>>>>> On Tue, Jun 9, 2015 at 4:50 PM, Tobias Soloschenko >>>>>> <tobiassolosche...@googlemail.com> wrote: >>>>>>> Saw that it is already set - isn't this enought - is it? >>>>>>> >>>>>>> kind regards >>>>>>> >>>>>>> Tobias >>>>>>> >>>>>>>> Am 09.06.2015 um 15:24 schrieb Martijn Dashorst < >>>>> martijn.dasho...@gmail.com>: >>>>>>>> >>>>>>>> All, >>>>>>>> >>>>>>>> I'm currently trying to build a release with Maven but ran into a >>> snag >>>>>>>> that Maven 3.3 doesn't support running on java 6 anymore. However I >>>>>>>> like to ensure our wicket 6.x releases are built with an actual Java >>> 6 >>>>>>>> release, so I am in the process of using toolchains [1] for the >>>>>>>> release building. >>>>>>>> >>>>>>>> Maven toolchains allow you to specify a required Java version in your >>>>>>>> pom, and in your local maven settings (~/.m2/toolchains.xml) where >>>>>>>> Maven can find the particular JDK version. >>>>>>>> >>>>>>>> This allows us to run Maven with Java 7 and compile using an actual >>>>> Java 6 JDK. >>>>>>>> >>>>>>>> Martijn >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Become a Wicket expert, learn from the best: http://wicketinaction.com > > > > -- > Become a Wicket expert, learn from the best: http://wicketinaction.com
