Hi,

> 
>>
>> - JS Code is not compressed/ optimized for production; so far only
>> comments are stripped out but no real optimization in terms of newline
>> (nearly 3k!) and whitespaces are done
>>
> 
> Not true!
> At
> https://github.com/apache/wicket/tree/master/wicket-core/src/main/java/org/apache/wicket/ajax/res/js
> there are only non-compressed but in the produced wicket-core.jar there are
> .min.js next to them.
> 
> 

Thats irritating, on our deployed live app with wicket 8.0.0-M7 (in production 
mode) these are not compressed?


>>

>> Beside this, it is also noticable that the jQuery JS file gets stripped of
>> its copyright notice, see:
>>
> 
> This must be
> https://github.com/apache/wicket/blob/411aa0ee38d45232f075549bf7212e78a0c626ce/wicket-core/src/main/java/org/apache/wicket/javascript/DefaultJavaScriptCompressor.java
> You can disable it with getResourceSettings().setJavaScriptCompressor(null)
> 

I'm not sure this is legally enough... I mean by default wicket strips legal 
notices.... I know this is annoying;

Reply via email to