On Wed, Mar 28, 2018 at 7:19 PM, Korbinian Bachl < [email protected]> wrote:
> IMHO: its 2018 and any browser sniffing has to be dropped at all, as it > has no use anyway and its not working reliable... what for do we need this > at all? > > even in 2009 it was considered bad: https://www.sitepoint.com/why- > browser-sniffing-stinks/ > and in case that is not enough, read what the guy that invented modernizr > has to say: > http://farukat.es/journal/2011/02/499-lest-we-forget-or- > how-i-learned-whats-so-bad-about-browser-sniffing/ > > I do not trust anyone who says "don't do it this way" but doesn't say how to do it! There are several of "if (isBrowserX()) {...} else {...}" in Wicket JS code and they served well for the last decade. Since there are several other *Java* libraries for user agent detection this means that someone still finds them useful despite what other people claim. > btw: > https://github.com/HaraldWalker/user-agent-utils -> this is EOL, guess > why... > https://github.com/pieroxy/java-user-agent-detection/releases -> last > release from september 2017... > > Sep 2017 is like yesterday > > ----- Ursprüngliche Mail ----- > > Von: "Maxim Solodovnik" <[email protected]> > > An: [email protected] > > Gesendet: Mittwoch, 28. März 2018 18:04:03 > > Betreff: [DISCUSSION] WICKET-6544 mobile browser detection > > > Hello All, > > > > While reviewing WICKET-6544 Martin propose to use JS library for this > task > > Here are some examples: > > https://github.com/pieroxy/java-user-agent-detection or > > https://github.com/HaraldWalker/user-agent-utils > > > > WDYT > > > > -- > > WBR > > Maxim aka solomax >
