Github user Jezza commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/276#discussion_r182876140
  
    --- Diff: wicket-core/src/main/java/org/apache/wicket/IMetadataContext.java 
---
    @@ -0,0 +1,10 @@
    +package org.apache.wicket;
    +
    +/**
    + * @author Jezza
    + */
    +public interface IMetadataContext<B, R> {
    --- End diff --
    
    I don't like the names of the generics, nor the R parameter.
    It was only added because the current implementation returns the object the 
method is enclosed in, so right now, it just conveys that type information.  
    Ideally, I would want to remove it.
    
    One solution would be just to return the IMetadataContext<B> itself, but 
you wouldn't be able to do much with the return result, short of just setting 
more metadata.


---

Reply via email to