Github user martin-g commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/276#discussion_r182965271
  
    --- Diff: wicket-core/src/main/java/org/apache/wicket/Session.java ---
    @@ -422,6 +422,7 @@ public Locale getLocale()
         * @return The metadata
         * @see MetaDataKey
         */
    +   @Override
        public synchronized final <M extends Serializable> M getMetaData(final 
MetaDataKey<M> key)
    --- End diff --
    
    Why in Application you moved `synchronized` in the method body and here it 
stays as before ? Is there any difference between the implementations ?


---

Reply via email to