On Fri, Jan 10, 2020 at 11:02 AM Martin Grigorov <[email protected]> wrote:
> > > On Fri, Jan 10, 2020 at 10:58 AM Maxim Solodovnik <[email protected]> > wrote: > >> `clean package` sounds more reasonable to me :) >> > > agreed, but let's change that only once we have a fix/workaround for the > problem > it seems it does not break the build, so it is OK to make this change now I will do it > > >> >> On Fri, 10 Jan 2020 at 15:57, Maxim Solodovnik <[email protected]> >> wrote: >> >> > `fast` profile skips javadoc .... >> > >> > On Fri, 10 Jan 2020 at 15:56, Martin Grigorov <[email protected]> >> > wrote: >> > >> >> Hi Emond, >> >> >> >> Locally while testing new JDK builds I always use: mvn14 clean install >> >> -Pfast,java14 >> >> mvn14 script just exports JAVA_HOME=$JAVA_14_HOME and calls mvn >> >> and I don't remember having issues with javadoc since a long time. >> >> >> >> On Fri, Jan 10, 2020 at 10:45 AM Emond Papegaaij < >> >> [email protected]> >> >> wrote: >> >> >> >> > Hi all, >> >> > >> >> > I just noticed a problem with building Wicket on JDK 14, which is not >> >> > detected by our current build setup. On JDK 13+, javadoc fails with: >> >> > >> >> > [ERROR] MavenReportException: Error while generating Javadoc: >> >> > Exit code: 1 - javadoc: error - invalid flag: --no-module-directories >> >> > >> >> > Command line was: /usr/lib/jvm/java-14-openjdk-amd64/bin/javadoc >> >> > -J-Xmx256m -J-Xms128m --no-module-directories @options @packages >> >> > >> >> > Shouldn't our build detect such issues? At the moment we run 'mvn >> >> > clean test'. Maybe we should run 'mvn clean package' instead? I'll >> >> > submit a bug report on maven-javadoc-plugin later today. It seems the >> >> > maintainers are not yet aware of this issue. >> >> > >> >> > Best regards, >> >> > Emond >> >> > >> >> >> > >> > >> > -- >> > WBR >> > Maxim aka solomax >> > >> >> >> -- >> WBR >> Maxim aka solomax >> >
