I've prepared a branch 'jakarta-api' with the migration to Jakarta, Servlet 4 and Jetty 10.0.0-alpha1. Most of the examples work fine, however I get an NPE on the websocket upgrade:
Caused by: java.lang.NullPointerException at org.eclipse.jetty.websocket.javax.common.JavaxWebSocketSession.getUserPrincipal(JavaxWebSocketSession.java:511) at org.apache.wicket.protocol.ws.javax.JavaxUpgradeHttpRequest.<init>(JavaxUpgradeHttpRequest.java:77) at org.apache.wicket.protocol.ws.javax.JavaxWebSocketProcessor.<init>(JavaxWebSocketProcessor.java:46) at org.apache.wicket.protocol.ws.javax.WicketEndpoint.onOpen(WicketEndpoint.java:65) at org.eclipse.jetty.websocket.javax.common.JavaxWebSocketFrameHandler.onOpen(JavaxWebSocketFrameHandler.java:197) On Fri, Jan 10, 2020 at 3:32 PM Martin Grigorov <[email protected]> wrote: > > On Fri, Jan 10, 2020 at 4:03 PM Emond Papegaaij <[email protected]> > wrote: > > > I tend to agree with Martijn here. The Jakarta APIs are the future. It > > is unfortunate that the last stable version of Jetty is 4 years old > > now and they have not been able to produce a new version in the past 2 > > years. Maybe us moving to servlet 4 will give them a bit more > > incentive to pick op the pace. > > > > I am -0. > I don't see the urge for this change > > > > > > For the examples, it should not be that hard to use a jetty 10 milestone. > > > > Emond > > > > On Fri, Jan 10, 2020 at 2:41 PM Jeroen Steenbeeke > > <[email protected]> wrote: > > > > > > Most of my Wicket applications (i.e. the ones I don't get paid to write) > > > run on Jetty 9.4, Java 11 and Wicket 8. > > > > > > Jetty 10 is, as indicated on the site I linked, still in alpha and marked > > > as unstable, and has no official Docker image yet. > > > > > > Right now there is nothing blocking me from adopting Wicket 9, > > introducing > > > servlet 4.0 would mean I cannot upgrade until Jetty stabilizes. > > > > > > - Jeroen > > > > > > Op vr 10 jan. 2020 om 14:29 schreef Martijn Dashorst < > > > [email protected]>: > > > > > > > On Fri, Jan 10, 2020 at 2:09 PM Jeroen Steenbeeke > > > > <[email protected]> wrote: > > > > > > > > > > Jetty is still on 3.1: > > > > > > > > > > > > > > > > https://www.eclipse.org/jetty/documentation/current/what-jetty-version.html > > > > > > > > Well, Emond was talking about the major application/servlet containers > > > > :-D... > > > > > > > > As we are targeting Java 11 with Wicket 9, perhaps 'ignoring' Jetty <= > > > > 9.x and aiming for Jetty 10 might not be *that* a big issue? > > > > > > > > Martijn > > > > > > > > > > > > > > > > > > Op vr 10 jan. 2020 om 14:05 schreef Emond Papegaaij < > > > > > [email protected]>: > > > > > > > > > > > It turns out Wicket 9 is still on servlet 3.1, which is > > pre-Jakarta. > > > > > > Any objections against raising this to 4.0? AFAIK all major > > > > > > application/servlet containers have versions with support for 4.0. > > > > > > > > > > > > Best regards, > > > > > > Emond > > > > > > > > > > > > On Fri, Jan 10, 2020 at 1:04 PM Martijn Dashorst > > > > > > <[email protected]> wrote: > > > > > > > > > > > > > > Just the maven coordinates. > > > > > > > > > > > > > > As for expected problems: probably folks have to update their > > poms to > > > > > > > use the jakarta variants, but mostly they shouldn't bite if they > > use > > > > > > > the provided scope. > > > > > > > > > > > > > > For benefits: > > > > > > > - the Jakarta group-id is the future, all servers will move to > > that > > > > > > > maven coordinate > > > > > > > - the licensing is now uniform (Eclipse) instead of whatever the > > spec > > > > > > > lead thought was good > > > > > > > - marketing: "Wicket has moved to use the Jakarta EE Maven > > artifacts, > > > > > > > embracing the future of Java Enterprise software development" > > > > > > > - hopefully the naming of the GAV will remain sane, instead of > > each > > > > > > > spec lead using a different naming scheme (even across versions) > > > > > > > > > > > > > > Martijn > > > > > > > > > > > > > > On Fri, Jan 10, 2020 at 12:03 PM Martin Grigorov < > > > > [email protected]> > > > > > > wrote: > > > > > > > > > > > > > > > > Hi Emond, > > > > > > > > > > > > > > > > If it is just about different Maven coordinates then it is OK. > > > > > > > > For the change javax.servlet -> jakarta.servlet it is too soon. > > > > > > > > > > > > > > > > On Fri, Jan 10, 2020 at 12:40 PM Emond Papegaaij < > > > > > > [email protected]> > > > > > > > > wrote: > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > While building our application against Wicket 9, I noticed > > Wicket > > > > > > > > > still uses the Java EE 8 APIs. I would like to change these > > to > > > > the > > > > > > > > > Jakarta versions. The APIs themselves are completely > > identical, > > > > it is > > > > > > > > > just the maven coordinate that changes. They do however come > > > > with a > > > > > > > > > better license (Eclipse). What do you think? > > > > > > > > > > > > > > > > > > Best regards, > > > > > > > > > Emond > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Become a Wicket expert, learn from the best: > > > > http://wicketinaction.com > > > > > > > > > > > > > > > > > > > > > -- > > > > > Jeroen Steenbeeke > > > > > > > > > > > > > > > > -- > > > > Become a Wicket expert, learn from the best: http://wicketinaction.com > > > > > > > > > > > > > -- > > > Jeroen Steenbeeke > >
