salcho commented on a change in pull request #439:
URL: https://github.com/apache/wicket/pull/439#discussion_r465266904
##########
File path:
wicket-core/src/main/java/org/apache/wicket/protocol/http/CsrfPreventionRequestCycleListener.java
##########
@@ -110,11 +110,15 @@
* <li>{@link #onSuppressed(HttpServletRequest, String, IRequestablePage)}
when an origin was in
* conflict and the request should be suppressed</li>
* </ul>
+ *
+ * @see FetchMetadataRequestCycleListener
+ * @deprecated
*/
-public class CsrfPreventionRequestCycleListener implements
IRequestCycleListener
+@Deprecated(since = "XXX")
Review comment:
This solution looks much better now. I've created a new
OriginBasedResourceIsolationPolicy, so Wicket will be able to defend against
CSRF attacks on modern and legacy browsers. I've set 9.1.0 as you said but
would be happy to iterate again if you think the Deprecated annotation
shouldn't be here yet.
Thanks for your review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
