svenmeier commented on pull request #439: URL: https://github.com/apache/wicket/pull/439#issuecomment-670466262
I think we're overdoing it ;) The actual implementation by @salcho was fine, for me the API wasn't just correct any more with all the old references to 'origin'. This is the simplest solution I can think of, e.g. renaming some methods and going through a change of responsibility in #checkRequest() is enough: https://gist.github.com/svenmeier/e2e29ddad37e453c693004946ab125e7 I'd deprecate the old listener, and give the new one a fancy new name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org