Thanks, I finished the code a week ago. I have compatability tests along with 100% test coverage and the change should make minimal impact to performance just waiting for employers permission to submit patch.
Thanks On Mon, Jul 19, 2021, 03:05 Colm O hEigeartaigh <[email protected]> wrote: > Hi Rob, > > Any contributions are welcome! I would prefer not to introduce a > dependency on powermock, it shouldn't be too much extra work to verify > the changes in a test. > > Colm. > > On Wed, Jul 14, 2021 at 11:07 PM Rob Leland <[email protected]> > wrote: > > > > For instance, > > > > Would the developers be open to adding a dependency for the PowerMock > reflection library so private methods could be tested, that way JUnits > tests could be smaller and easier to understand. > > > > On Wed, Jul 14, 2021, 17:23 Rob Leland <[email protected]> wrote: > >> > >> I am in the early stages of making changes based on 2.3.3 to make this > class optionally emit the DN name in a way that WCF likes. > >> > >> Specifically it will: > >> 1) place spaces before each RDN. > >> 2) Instead of escaping embedded commas and semicolons with a back > slash to use quotes around the RDN text. > >> > >> so > >> OU=(c) 2021 Entrust\, Inc. > >> > >> becomes > >> OU="(c) 2021 Entrust, Inc." > >> > >> The first pass is using the underlying needed oracle code which is > almost done , and the next pass would be a clean implementation. > >> > >> There are a few basic tests to cover my use case. > >> > >> The default behaviour would be unchanged. > >> > >> My question is this, beyond the contrib agreement, I was formally > [email protected] > >> what other hurdles other than PR review would there be to eventually > integrating this change to the baseline ? > >> > >> Thanks for your time and wss4j! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
