On Fri, Sep 27, 2013 at 10:18 AM, Isuru Wimalasundera <isu...@wso2.com>wrote:
> Hi IsuruU > > > On Fri, Sep 27, 2013 at 8:49 AM, Isuru Udana <isu...@wso2.com> wrote: > >> On Fri, Sep 27, 2013 at 8:27 AM, Nuwan Dias <nuw...@wso2.com> wrote: >> >>> Since this is an addition of 2 new methods, I don't think it'll have an >>> impact unless someone tries to install new features to a product released >>> on an older chunk. Ex: If someone tries to install APIM (chunk2) features >>> on top of AS 5.2.0 (chunk1), then there'll be a problem. But in this kind >>> of situation we anyway have to ask people to install all kernel patches >>> since there are bug fixes anyway. >>> >> >> No. This has an impact for the next chunk releases. >> If we are going to create a org.wso2.carbon.registry.indexing 4.2.2 or >> some component use this api change in chunk-03 or later chunks. we always >> have to build patch0001 even it is released. >> > > I am not sure why that is necessary, its true you have to build patch0001 > till its being released with the chunk02 in case if any component have a > dependency to the so called API change. but after the release AFAIK all the > Kernel fixes done in patch0001 should be reflected in the Nexus repo , > right? or am I missing something here. > AFAIK we only deploy kernel patch .zip to the nexus not the jars inside the patch. > >> >>> Thanks, >>> NuwanD. >>> >>> >>> On Fri, Sep 27, 2013 at 12:51 AM, Ajith Vitharana <aji...@wso2.com>wrote: >>> >>>> >>>> >>>> >>>> On Fri, Sep 27, 2013 at 12:22 AM, Sumedha Rubasinghe >>>> <sume...@wso2.com>wrote: >>>> >>>>> >>>>> >>>>> >>>>> On Thu, Sep 26, 2013 at 11:57 PM, Ajith Vitharana <aji...@wso2.com>wrote: >>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Thu, Sep 26, 2013 at 11:35 PM, Lalaji Sureshika >>>>>> <lal...@wso2.com>wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> From this fix, only a new method has added and no existing API >>>>>>> method changes happened .Thus will this be cause any problem..? >>>>>>> From APIM side,we need this fix,to integrate registry pagination in >>>>>>> APIM [which has increased the performance of APIs loading in APIStore ] >>>>>>> and >>>>>>> this is a bug fix,which hasn't identified before chunk1 release out.. >>>>>>> >>>>>> >>>>>> Feature development and integrations can't avoid after chunk01 >>>>>> release, we have to face limitations or bugs. >>>>>> If the feature/bug is critical for the given release, we need some >>>>>> alternative than preventing API changes. >>>>>> >>>>> >>>>> But this violates chunk release strategy. Your features will not be >>>>> compatible within platform. >>>>> Please get Sameera's input on this. >>>>> >>>> >>>> It is not practical to develop/integrate feature at *chunk01* to >>>> compatible in all over the platform. >>>> >>>> Eg: How to test/integrate AM with pagination at the *chunk01* without >>>> proper AM build (or distributed setup) ???. >>>> At the chunk01 we did AS, IS but pagination didn't involved with those >>>> products. >>>> >>>> My suggestion is we should restrict the API changes once we finished at >>>> least one release of the all the products from a given kernel release. >>>> Because kernel 4.2.0 based product releases are major releases that >>>> involves many new features and integrations, therefore nothing to wonder >>>> with API changes. >>>> >>>> Thanks >>>> Ajith. >>>> >>>> >>>>> >>>>> >>>>> >>>>>> Thanks >>>>>> Ajith >>>>>> >>>>>> >>>>>>> >>>>>>> Thanks; >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Thu, Sep 26, 2013 at 11:19 PM, Isuru Udana <isu...@wso2.com>wrote: >>>>>>> >>>>>>>> Hi Lalaji, >>>>>>>> >>>>>>>> AFAIK api changes are not allowed for Kernel patches. We had a >>>>>>>> similar case for 4.1.3 and had to revert that at the last moment. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On Thu, Sep 26, 2013 at 11:14 PM, Lalaji Sureshika <lal...@wso2.com >>>>>>>> > wrote: >>>>>>>> >>>>>>>>> Hi Isuru, >>>>>>>>> >>>>>>>>> This fix was added by Ajith as part of the fix an issue on >>>>>>>>> registry pagination with APIM integration.AFAIK,by this change a new >>>>>>>>> getter/setter has added to PaginationContext class. Refer the jira [1] >>>>>>>>> >>>>>>>> >>>>>>>>> [1] https://wso2.org/jira/browse/REGISTRY-2003 >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks; >>>>>>>>> >>>>>>>>> >>>>>>>>> On Thu, Sep 26, 2013 at 11:03 PM, Isuru Udana <isu...@wso2.com>wrote: >>>>>>>>> >>>>>>>>>> I am getting the following build failure. >>>>>>>>>> >>>>>>>>>> [ERROR] Failed to execute goal >>>>>>>>>> org.apache.maven.plugins:maven-compiler-plugin:2.3.2:compile >>>>>>>>>> (default-compile) on project org.wso2.carbon.registry.indexing: >>>>>>>>>> Compilation >>>>>>>>>> failure >>>>>>>>>> [ERROR] >>>>>>>>>> /media/isuru/WSO2/svn/public/4.2.0/platform/4.2.0/components/registry/org.wso2.carbon.registry.indexing/4.2.1/src/main/java/org/wso2/carbon/registry/indexing/service/ContentBasedSearchService.java:[140,33] >>>>>>>>>> cannot find symbol >>>>>>>>>> [ERROR] symbol : method setLength(int) >>>>>>>>>> [ERROR] location: class >>>>>>>>>> org.wso2.carbon.registry.core.pagination.PaginationContext >>>>>>>>>> [ERROR] -> [Help 1] >>>>>>>>>> [ERROR] >>>>>>>>>> [ERROR] To see the full stack trace of the errors, re-run Maven >>>>>>>>>> with the -e switch. >>>>>>>>>> [ERROR] Re-run Maven using the -X switch to enable full debug >>>>>>>>>> logging. >>>>>>>>>> [ERROR] >>>>>>>>>> [ERROR] For more information about the errors and possible >>>>>>>>>> solutions, please read the following articles: >>>>>>>>>> [ERROR] [Help 1] >>>>>>>>>> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException >>>>>>>>>> [ERROR] >>>>>>>>>> [ERROR] After correcting the problems, you can resume the build >>>>>>>>>> with the command >>>>>>>>>> [ERROR] mvn <goals> -rf :org.wso2.carbon.registry.indexing >>>>>>>>>> >>>>>>>>>> This got resolved after building kernel patch0001. >>>>>>>>>> Are we allow API changes in kernel patches now ? >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Isuru Udana* >>>>>>>>>> * >>>>>>>>>> * >>>>>>>>>> Senior * >>>>>>>>>> Software Engineer >>>>>>>>>> * >>>>>>>>>> WSO2 Inc.; http://wso2.com >>>>>>>>>> email: isu...@wso2.com cell: +94 77 3791887 >>>>>>>>>> blog: http://mytecheye.blogspot.com/ >>>>>>>>>> twitter: http://twitter.com/isudana >>>>>>>>>> >>>>>>>>>> _______________________________________________ >>>>>>>>>> Dev mailing list >>>>>>>>>> Dev@wso2.org >>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Lalaji Sureshika >>>>>>>>> WSO2, Inc.; http://wso2.com/ >>>>>>>>> email: lal...@wso2.com; cell: +94 71 608 6811 >>>>>>>>> blog: http://lalajisureshika.blogspot.com >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Isuru Udana* >>>>>>>> * >>>>>>>> * >>>>>>>> Senior * >>>>>>>> Software Engineer >>>>>>>> * >>>>>>>> WSO2 Inc.; http://wso2.com >>>>>>>> email: isu...@wso2.com cell: +94 77 3791887 >>>>>>>> blog: http://mytecheye.blogspot.com/ >>>>>>>> twitter: http://twitter.com/isudana >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Lalaji Sureshika >>>>>>> WSO2, Inc.; http://wso2.com/ >>>>>>> email: lal...@wso2.com; cell: +94 71 608 6811 >>>>>>> blog: http://lalajisureshika.blogspot.com >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Ajith Vitharana. >>>>>> WSO2 Inc. - http://wso2.org >>>>>> Email : aji...@wso2.com >>>>>> Mobile : +94772217350 >>>>>> >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> Dev@wso2.org >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> /sumedha >>>>> m: +94 773017743 >>>>> b : bit.ly/sumedha >>>>> >>>> >>>> >>>> >>>> -- >>>> Ajith Vitharana. >>>> WSO2 Inc. - http://wso2.org >>>> Email : aji...@wso2.com >>>> Mobile : +94772217350 >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Nuwan Dias >>> >>> Senior Software Engineer - WSO2, Inc. http://wso2.com >>> email : nuw...@wso2.com >>> Phone : +94 777 775 729 >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Isuru Udana* >> * >> * >> Senior * >> Software Engineer >> * >> WSO2 Inc.; http://wso2.com >> email: isu...@wso2.com cell: +94 77 3791887 >> blog: http://mytecheye.blogspot.com/ >> twitter: http://twitter.com/isudana >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Isuru Wimalasundera* > Senior Software Engineer; > WSO2, Inc.; http://wso2.com, > mobile: +94 77 920 5641 > -- *Isuru Udana* * * Senior * Software Engineer * WSO2 Inc.; http://wso2.com email: isu...@wso2.com cell: +94 77 3791887 blog: http://mytecheye.blogspot.com/ twitter: http://twitter.com/isudana
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
