Hi, IMO we really need to figure out ways to make the UIs more responsive. At the moment they are not responsive enough. For a user it is too misleading sometimes. After clicking the build button it should be disabled until the build finishes. Further more I don't think that we need to look for successful build to deploy (Don't need to go through all the builds to look for a successful build). Considering the last build is enough. Someone who has written new code and pushed it to the repo will not want to deploy an earlier build as his/her is considering only the last build.
Thanks. GayanD Gayan Dhanuska Software Engineer http://wso2.com/ Lean Enterprise Middleware Mobile 071 666 2327 Office Tel : 94 11 214 5345 Fax : 94 11 214 5300 Twitter : https://twitter.com/gayanlggd On Fri, Nov 1, 2013 at 8:12 AM, Ashansa Perera <asha...@wso2.com> wrote: > Hi all, > > IMO too enabling deploy button only if there is a successful build would > need a lot of calls to jenkins as Danushka has also explained and it may > not enough to do in page reload time too. So it would be good to show a > notification if no successful build is there. But currently what we do is > we programatically trigger a build if no successful build is there when > user ask to deploy. But yes if that build fails the deployment will fail. > If we are going to do this button disabling if no successful build is > there, we may need to avoid building programatically. > > Regarding enabling the deploy button after the deployment successful : > IMHO this is a main feature that we should add - a notification framework > since most of our actions are async. > And we should enable the button after trying to deploy ( means even the > deployment is successful or not ) Else the user will be stuck if the > deployment fails. But here I agree with Ramith, is there a specific reason > for disabling the button until deployment finishes? For me too it does not > seems to be a must thing to have. > > > > > On Thu, Oct 31, 2013 at 6:12 PM, Ramith Jayasinghe <ram...@wso2.com>wrote: > >> To me also disabling buttons doesn't look attractive. But if we go down >> this path we can add a tool tip saying when the button is enabled etc. >> What seems best (and simple to implement would be) showing a dialog >> saying there is no build available yet. >> >> >> On Thu, Oct 31, 2013 at 5:56 PM, Danushka Fernando <danush...@wso2.com>wrote: >> >>> Please check inline comments. >>> >>> On Thu, Oct 31, 2013 at 5:29 PM, Harsha Thirimanna <hars...@wso2.com>wrote: >>> >>>> Hi, >>>> >>>> *Enable deploy only if there is a successful build* >>>> https://wso2.org/jira/browse/APPFAC-1644 >>>> We can get the lastSuccessfulBuild id from jenkins to given job. When >>>> we click on the deploy button, we can check whether there is at least one >>>> lastSuccessfulBuild id and if there are no one then show the message to the >>>> user. >>>> >>>> Any suggestion about this ? >>>> >>>> Issue is proposing to disable the button when no successful builds are >>> there. So >>> 1. I thought we have removed lot of disabling buttons because this >>> confuses the user. >>> 2. If we disable buttons each time this page loads there will be lot of >>> calls going to jenkins to check for successful builds to just disable the >>> deploy button. And if we have 10 branches there there will be 10 calls for >>> each page load. >>> So without disabling the button its better to let the user click the >>> button and popup a message saying there are no successful builds available. >>> Please build first. This will reduce the unnecessary calls. WDYT? >>> >>> >>>> *Enable the deploy button after it is deployed* >>>> https://wso2.org/jira/browse/APPFAC-1645 >>>> To do this we have to sync with deployed servers to check the >>>> deployment status. Then there may be lot of calls to back end according to >>>> the above suggestion. >>>> Are there any other ways to do this ? >>>> >>>> We do the deploy as an async operation. However lets say we implement >>> this. There are two concerns for me. >>> 1. What happens at page reload. Does it re-enable? >>> 2. What happens if deploy fails for some reason. User wont be able to >>> deploy that branch again. >>> >>> And I think disabling buttons will confuses the user since user doesn't >>> know when this button will be enabled. WDYT? >>> >>>> >>>> thanks >>>> >>>> *Harsha Thirimanna* >>>> Senior Software Engineer; WSO2, Inc.; http://wso2.com >>>> * <http://www.apache.org/>** >>>> email: **hars...@wso2.com* <az...@wso2.com>* cell: +94 71 5186770** >>>> twitter: **http://twitter.com/ <http://twitter.com/afkham_azeez>** >>>> harshathirimann >>>> linked-in: **http: <http://lk.linkedin.com/in/afkhamazeez>**// >>>> www.linkedin.com/pub/harsha-thirimanna/10/ab8/122* >>>> * >>>> * >>>> *Lean . Enterprise . Middleware* >>>> * >>>> * >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> Thanks & Regards >>> Danushka Fernando >>> Software Engineer >>> WSO2 inc. http://wso2.com/ >>> Mobile : +94716332729 >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Ramith Jayasinghe >> Technical Lead >> WSO2 Inc., http://wso2.com >> lean.enterprise.middleware >> >> E: ram...@wso2.com >> P: +94 776715671 >> >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Thanks & Regards, > > Ashansa Perera > Software Engineer > WSO2, Inc > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > >
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
