On Wed, Aug 6, 2014 at 5:35 PM, Shameera Rathnayaka <shame...@wso2.com> wrote:
> Hi Azeez, > > On Wed, Aug 6, 2014 at 5:11 PM, Afkham Azeez <az...@wso2.com> wrote: > >> Yes, ideally we should have exported only javax.cache.*. However, I think >> one of Asela's patch has a coupling to CacheImpl since caching API does not >> provide a way to set the cache capacity. However, there are no API changes >> in CacheImpl. >> > > There are API changes in CacheImpl class ( it has two public method to > get size and cache capacity). and both are used in classes in eviction > package. In that case what should we do? > > > I can remove those methods. Let me do that & resend the patch. > Thanks, > Shameera. > > > The only API changes are in the org.wso2.carbon.caching.impl.eviction >> package. That package is totally internal to the caching impl. We can make >> that private. >> >> >> On Wed, Aug 6, 2014 at 4:50 PM, Shameera Rathnayaka <shame...@wso2.com> >> wrote: >> >>> Hi Azeez, >>> >>> Saw that "org.wso2.carbon.caching.impl.*, " is there under export >>> packages, should this expose the latest API addition to the outside at >>> runtime?. My understand is this can be an issue in future. WDYT? if this >>> is the only way to patch this, isn't it better we make all new API private >>> to this bundle, i mean configure it as private package? >>> >>> Thanks, >>> Shameera. >>> >>> >>> >>> >>> On Wed, Aug 6, 2014 at 2:32 PM, Afkham Azeez <az...@wso2.com> wrote: >>> >>>> There are API changes within java.cache, but all of those changes >>>> affect only that bundle, and are internal to that bundle, and don't affect >>>> the bundles outside it. Hence, there is no issue in committing the caching >>>> fix. >>>> >>>> >>>> On Wed, Aug 6, 2014 at 2:28 PM, Asela Pathberiya <as...@wso2.com> >>>> wrote: >>>> >>>>> Hi Shameera, >>>>> >>>>> There is no any API in user core patch... We have only added a >>>>> private method. As i got to know, It is not allowed to add even >>>>> private method. Therefore i modified the code and attached the patch >>>>> in to the jira. >>>>> >>>>> AFAIK, there is no any caching API changes in caching.core as well... >>>>> >>>>> Therefore i hope it is fine to apply the patches... >>>>> >>>>> Adding Azeez... >>>>> >>>>> Thanks, >>>>> Asela. >>>>> >>>>> On Wed, Aug 6, 2014 at 2:13 PM, Shameera Rathnayaka <shame...@wso2.com> >>>>> wrote: >>>>> > Hi Asela, >>>>> > >>>>> > As we discussed, it is not allowed to do any API changes to 4.2.0 >>>>> patches. >>>>> > So please reattached the patch removing all API changes. And the >>>>> already >>>>> > attached patch can be applied to 4.3.0 git repo. So please send >>>>> those as >>>>> > pull request. >>>>> > >>>>> > Thanks, >>>>> > Shameera. >>>>> > >>>>> > >>>>> > On Wed, Aug 6, 2014 at 1:02 PM, Asela Pathberiya <as...@wso2.com> >>>>> wrote: >>>>> >> >>>>> >> Hi All, >>>>> >> >>>>> >> Please commit following >>>>> >> >>>>> >> https://wso2.org/jira/browse/CARBON-14891 >>>>> >> https://wso2.org/jira/browse/CARBON-14905 >>>>> >> >>>>> >> Thanks, >>>>> >> Asela. >>>>> >> >>>>> >> -- >>>>> >> Thanks & Regards, >>>>> >> Asela >>>>> >> >>>>> >> ATL >>>>> >> Mobile : +94 777 625 933 >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > -- >>>>> > Software Engineer - WSO2 Inc. >>>>> > email: shameera AT wso2.com , shameera AT apache.org >>>>> > phone: +9471 922 1454 >>>>> > >>>>> > Linked in : >>>>> http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>>>> > Twitter : https://twitter.com/Shameera_R >>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Asela >>>>> >>>>> ATL >>>>> Mobile : +94 777 625 933 >>>>> >>>> >>>> >>>> >>>> -- >>>> *Afkham Azeez* >>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>> Member; Apache Software Foundation; http://www.apache.org/ >>>> * <http://www.apache.org/>* >>>> *email: **az...@wso2.com* <az...@wso2.com> >>>> * cell: +94 77 3320919 <%2B94%2077%203320919> blog: * >>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>> *twitter: **http://twitter.com/afkham_azeez* >>>> <http://twitter.com/afkham_azeez> >>>> * linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>> >>>> *Lean . Enterprise . Middleware* >>>> >>> >>> >>> >>> -- >>> *Software Engineer - WSO2 Inc.* >>> *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT >>> apache.org <shame...@apache.org>* >>> *phone: +9471 922 1454 <%2B9471%20922%201454>* >>> >>> *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>> *Twitter : *https://twitter.com/Shameera_R >>> >> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>* >> *email: **az...@wso2.com* <az...@wso2.com> >> * cell: +94 77 3320919 <%2B94%2077%203320919> blog: * >> *http://blog.afkham.org* <http://blog.afkham.org> >> *twitter: **http://twitter.com/afkham_azeez* >> <http://twitter.com/afkham_azeez> >> * linked-in: **http://lk.linkedin.com/in/afkhamazeez >> <http://lk.linkedin.com/in/afkhamazeez>* >> >> *Lean . Enterprise . Middleware* >> > > > > -- > *Software Engineer - WSO2 Inc.* > *email: shameera AT wso2.com <shame...@wso2.com> , shameera AT apache.org > <shame...@apache.org>* > *phone: +9471 922 1454 <%2B9471%20922%201454>* > > *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 > *Twitter : *https://twitter.com/Shameera_R > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>* *email: **az...@wso2.com* <az...@wso2.com> * cell: +94 77 3320919 blog: **http://blog.afkham.org* <http://blog.afkham.org> *twitter: **http://twitter.com/afkham_azeez* <http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez <http://lk.linkedin.com/in/afkhamazeez>* *Lean . Enterprise . Middleware*
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
