Hi Ruwan, Yes, there are many similar hard coded texts in the existing code base and I think we need to change all the occurrences..
Thanks.. On Tue, Dec 16, 2014 at 10:25 PM, Ruwan Yatawara <[email protected]> wrote: > > Hi Lahiru, > > Small suggestion. Noticed that a bunch of text such as Allows 5 > request(s) per minute. are hard coded. Actually these tier value are > subject to change once the tiers.xml is changed. > > Hence it would be best to load these values dynamically, else it would be > reported as another bug later on. > > Thanks and Regards, > > Ruwan Yatawara > > Senior Software Engineer, > WSO2 Inc. > > email : [email protected] > mobile : +94 77 9110413 > blog : http://thoughts.ruwan-ace.com/ > www: :http://wso2.com > > > On Tue, Dec 16, 2014 at 6:55 PM, Lahiru Cooray <[email protected]> wrote: >> >> Hi, >> >> Please merge the PR >> https://github.com/wso2/app-manager/pull/92 >> >> >> -- >> *Lahiru Cooray* >> Software Engineer >> WSO2, Inc.;http://wso2.com/ >> lean.enterprise.middleware >> >> Mobile: +94 715 654154 >> > -- *Lahiru Cooray* Software Engineer WSO2, Inc.;http://wso2.com/ lean.enterprise.middleware Mobile: +94 715 654154
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
