Hi SupunM, I have done the changes.
Thanks On Wed, Feb 25, 2015 at 12:47 PM, Supun Malinga <[email protected]> wrote: > Hi Chanika, > > There are some issues with Exception handling. We need to see and catch > only specific Exceptions. Please see to it and fix appropriately. Add code > comments explaining why, if you really need to catch 'Exception'. > > thanks, > > On Wed, Feb 25, 2015 at 10:11 AM, Supun Malinga <[email protected]> wrote: > >> Will do Sameera. >> >> On Tue, Feb 24, 2015 at 4:32 PM, Sameera Jayasoma <[email protected]> >> wrote: >> >>> Hi SupunM, >>> >>> Can you review this and commit? >>> >>> Thanks, >>> Sameera. >>> >>> On Tue, Feb 24, 2015 at 1:47 PM, Chanika Geeganage <[email protected]> >>> wrote: >>> >>>> Done the changes according to comments >>>> >>>> @Kernel Team, >>>> >>>> Can you please merge the PR >>>> https://github.com/wso2/carbon4-kernel/pull/147 >>>> >>>> Thanks >>>> >>>> On Tue, Feb 24, 2015 at 1:04 PM, Johann Nallathamby <[email protected]> >>>> wrote: >>>> >>>>> Commented on the PR. Once resolved can merge PR. >>>>> >>>>> On Tue, Feb 24, 2015 at 12:29 PM, Chanika Geeganage <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> The user.core depends on ndatasource.rdbms module to get a datasource >>>>>> for realm datasource and user store datasource. Recently we had to add >>>>>> ndatasource.core dependency to ndatasource.rdbms module in order to fix >>>>>> an >>>>>> issue. Then it created a cyclic dependency with the following order. >>>>>> >>>>>> org.wso2.carbon.ndatasource.core --> org.wso2.carbon.core --> >>>>>> org.wso2.carbon.registry.core --> org.wso2.carbon.user.core --> >>>>>> org.wso2.carbon.ndatasource.rdbms --> org.wso2.carbon.ndatasource.core >>>>>> >>>>>> As the user.core module is in top of the dependency tree, it should >>>>>> not be depend on a module which is in the lower level in the dependency >>>>>> tree. Therefore I have changed the user.core module to directly get >>>>>> datasource using tomcat.jdbc.pool.DataSource. The PR [1] has the changes >>>>>> done. >>>>>> >>>>>> @Johann Please review the PR >>>>>> >>>>>> [1] https://github.com/wso2/carbon4-kernel/pull/147 >>>>>> >>>>>> -- >>>>>> Best Regards.. >>>>>> >>>>>> Chanika Geeganage >>>>>> Software Engineer >>>>>> Mobile : +94773522586 >>>>>> WSO2, Inc.; http://wso2.com >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> >>>>> *Johann Dilantha Nallathamby* >>>>> Associate Technical Lead & Product Lead of WSO2 Identity Server >>>>> Integration Technologies Team >>>>> WSO2, Inc. >>>>> lean.enterprise.middleware >>>>> >>>>> Mobile - *+94777776950* >>>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>>> >>>> >>>> >>>> >>>> -- >>>> Best Regards.. >>>> >>>> Chanika Geeganage >>>> Software Engineer >>>> Mobile : +94773522586 >>>> WSO2, Inc.; http://wso2.com >>>> >>>> >>> >>> >>> -- >>> Sameera Jayasoma, >>> Software Architect, >>> >>> WSO2, Inc. (http://wso2.com) >>> email: [email protected] >>> blog: http://blog.sameera.org >>> twitter: https://twitter.com/sameerajayasoma >>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections >>> Mobile: 0094776364456 >>> >>> Lean . Enterprise . Middleware >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Supun Malinga, >> >> Senior Software Engineer, >> WSO2 Inc. >> http://wso2.com >> email: [email protected] <[email protected]> >> mobile: +94 (0)71 56 91 321 >> > > > > -- > Supun Malinga, > > Senior Software Engineer, > WSO2 Inc. > http://wso2.com > email: [email protected] <[email protected]> > mobile: +94 (0)71 56 91 321 > -- Best Regards.. Chanika Geeganage Software Engineer Mobile : +94773522586 WSO2, Inc.; http://wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
