I don't think this a major issue to fix. Normally if you apply a patch, you don't partially remove some jars from the patch directory as if you are trying to update a patch. Either you remove that patch completely or apply a new patch. IMO there is no concept of updating a patch rather you update your system with a patch.
On Wed, Jun 8, 2016 at 6:55 AM, Niranjan Karunanandham <niran...@wso2.com> wrote: > Hi Nuwan, > > As per the logic in [1], when the jar is removed, the patches are not > updated. But as mentioned by you, as a solution we can revert the jar by > removing the patch directory and restarting the server. > > [1] - > https://github.com/wso2/carbon-kernel/blob/v4.4.5/core/org.wso2.carbon.server/src/main/java/org/wso2/carbon/server/extensions/PatchInstaller.java > > Regards, > Nira > > On Tue, Jun 7, 2016 at 7:22 PM, Nuwan Wimalasekara <nuw...@wso2.com> > wrote: > >> Hi, >> >> Seems this is a bug. reported a JIRA[1] to track the issue further. >> >> [1] https://wso2.org/jira/browse/CARBON-15939 >> >> Thanks, >> Nuwanw >> >> On Wed, Jun 1, 2016 at 12:21 PM, Nuwan Wimalasekara <nuw...@wso2.com> >> wrote: >> >>> Hi Manoj, >>> >>> Yes. Even if the jar is removed, plugin directory has the same md5 value >>> of removed jar. means It is not reverted. >>> >>> To revert the jar, we have to remove the patch directory and restart the >>> server. >>> >>> Thanks, >>> Nuwanw >>> >>> On Wed, Jun 1, 2016 at 12:03 PM, Manoj Kumara <ma...@wso2.com> wrote: >>> >>>> During patch application it validate the md5sum's of the jars as well. >>>> Can you please verify the removed jar has a different md5 value from what's >>>> there in the server ? >>>> >>>> *Manoj Kumara* >>>> WSO2 Inc. *| **lean. enterprise. middleware.* >>>> *Mobile:* +94 713 448188 >>>> >>>> On Wed, Jun 1, 2016 at 11:53 AM, Nuwan Wimalasekara <nuw...@wso2.com> >>>> wrote: >>>> >>>>> Hi Carbon Team, >>>>> >>>>> I have observed $subject when I try to remove a jar file from patch >>>>> directory. I know removing a jar file from patch directory is not a good >>>>> practise when applying patches. But it may happen and then the behaviour >>>>> is >>>>> confusing. However if we update the a jar file inside a patch , it will >>>>> reflect and update the plugins directory and works as expected. >>>>> >>>>> To reproduce the issue, we can apply a patch having two jar file and >>>>> restart the server. Then it will apply the patch. after that, remove one >>>>> of >>>>> jar file in the patch directory and restart the server. The it will not >>>>> detect as a patch change and will not revert the removed jar from >>>>> patch0000. >>>>> >>>>> Is this a limitation in patch applying process or bug? >>>>> >>>>> Thanks, >>>>> Nuwanw >>>>> >>>>> -- >>>>> Nuwan Wimalasekara >>>>> Senior Software Engineer - Test Automation >>>>> WSO2, Inc.: http://wso2.com >>>>> lean. enterprise. middleware >>>>> >>>>> phone: +94 71 668 4620 >>>>> >>>>> >>>>> >>>>> >>>> >>> >>> >>> -- >>> Nuwan Wimalasekara >>> Senior Software Engineer - Test Automation >>> WSO2, Inc.: http://wso2.com >>> lean. enterprise. middleware >>> >>> phone: +94 71 668 4620 >>> >>> >>> >>> >> >> >> -- >> Nuwan Wimalasekara >> Associate Technical Lead >> WSO2, Inc.: http://wso2.com >> lean. enterprise. middleware >> >> phone: +94 71 668 4620 >> >> >> >> >> _______________________________________________ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > > *Niranjan Karunanandham* > Associate Technical Lead - WSO2 Inc. > WSO2 Inc.: http://www.wso2.com > > _______________________________________________ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- *Kishanthan Thangarajah* Technical Lead, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
