Hi Akila, Thank you for the feedback and please accept my apologies for the delayed response. I updated the code according to the guidelines you have provided on coding standards and pushed it to the repository [1]. tenantId is used here [2]. I'm not familiar with Netflix Feign standard on HTTP requests. Can you please explain it briefly or mention a link to a tutorial?
[1] https://github.com/osuran/azure-membership-scheme [2] https://github.com/osuran/azure-membership-scheme/blob/master/src/main/java/org/wso2/carbon/clustering/azure/AzureMembershipScheme.java#L168 Thanks, On Fri, Jun 24, 2016 at 10:49 PM, Imesh Gunaratne <im...@wso2.com> wrote: > > > On Fri, Jun 24, 2016 at 10:43 PM, Akila Ravihansa Perera < > raviha...@wso2.com> wrote: > >> Hi Osura, >> >> I still see some issues in the code. >> >> 1. Make sure to use consts when appropriate [1] >> 2. Where do you use tenantId [2] ? >> 3. Use the actual parameter key in the error message [3] instead of hard >> coding it >> 4. You need to adhere to max line len of 120 chars. I see this standard >> being violated in couple of places [4]. Use IDE formatting tool to fix this >> 5. Do not keep empty spaces [5]. This is bad code styling >> >> @Imesh: Osura has used Apache HTTP client to send HTTP requests [6]. >> Shall we make Netflix Feign the standard for this? >> > > +1 Yes, definitely. > > Thanks > > >> >> [1] >> https://github.com/osuran/azure-membership-scheme/blob/master/src/main/java/org/wso2/carbon/clustering/azure/AzureMembershipScheme.java#L117 >> [2] >> https://github.com/osuran/azure-membership-scheme/blob/master/src/main/java/org/wso2/carbon/clustering/azure/AzureMembershipScheme.java#L107 >> [3] >> https://github.com/osuran/azure-membership-scheme/blob/master/src/main/java/org/wso2/carbon/clustering/azure/AzureMembershipScheme.java#L148 >> [4] >> https://github.com/osuran/azure-membership-scheme/blob/master/src/main/java/org/wso2/carbon/clustering/azure/AzureMembershipScheme.java#L181 >> [5] >> https://github.com/osuran/azure-membership-scheme/blob/master/src/main/java/org/wso2/carbon/clustering/azure/AzureMembershipScheme.java#L94 >> [6] >> https://github.com/osuran/azure-membership-scheme/blob/master/src/main/java/org/wso2/carbon/clustering/azure/AzureMembershipScheme.java#L234 >> >> Thanks. >> >> On Fri, Jun 24, 2016 at 11:05 AM, Imesh Gunaratne <im...@wso2.com> wrote: >> >>> >>> >>> On Fri, Jun 24, 2016 at 11:00 AM, <osura...@gmail.com> wrote: >>> >>>> Hi Imesh, >>>> >>>> Yes I completed the evaluation. >>>> >>> Great! Thanks! >>> >>>> Thanks, >>>> >>>> Get Outlook for Android <https://aka.ms/ghei36> >>>> >>>> >>>> >>>> On Fri, Jun 24, 2016 at 10:08 AM +0530, "Imesh Gunaratne" < >>>> im...@wso2.com> wrote: >>>> >>>> Hi Osura, >>>>> >>>>> Were you able to submit the midterm evaluation? Might be better to do >>>>> it soon. >>>>> >>>>> Thanks >>>>> Imesh >>>>> >>>>> >>> >>> >>> -- >>> *Imesh Gunaratne* >>> Software Architect >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: https://medium.com/@imesh TW: @imesh >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> Akila Ravihansa Perera >> WSO2 Inc.; http://wso2.com/ >> >> Blog: http://ravihansa3000.blogspot.com >> > > > > -- > *Imesh Gunaratne* > Software Architect > WSO2 Inc: http://wso2.com > T: +94 11 214 5345 M: +94 77 374 2057 > W: https://medium.com/@imesh TW: @imesh > Lean . Enterprise . Middleware > > -- Regards, Osura Rathnayake
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
